[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-08-27 6:37:56
Message-ID: 20150827063756.4103.14473 () mimi ! kde ! org
[Download RAW message or body]
--===============6427763603900644695==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 26, 2015, 8:51 p.m., Kai Uwe Broulik wrote:
> > Just place the
> >
> > anchors {
> > horizontalCenter: parent.horizontalCenter
> > bottom: parent.bottom
> > }
> >
> > into the Loader to ensure the OSD is correctly positioned. I think the OSD should \
> > be loaded on demand, the first time it's to be shown.
> > Also, Loader has an active property you can set to false and then set to true \
> > when you want the item to load. This way you can have the Loader's source where \
> > it belongs.
Thanks. Completely delaying the OSD seems to be not practicle as the greeterApp looks \
for the osd object and does not trigger the osd if there is no such object. Thus the \
object must exist before the OSD is activated.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124933/#review84417
-----------------------------------------------------------
On Aug. 27, 2015, 8:36 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124933/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2015, 8:36 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This fixes type errors shown on startup:
> TypeError: Cannot read property 'showPassword' of undefined
> TypeError: Cannot read property 'ButtonLabel' of undefined
>
> REVIEW: 124931
>
> [screenlocker] Try to load faster by using more loaders
>
> All UI is put into a loader to get the actual lock screen loaded faster.
> This gets the creation of two views down to about < 600 msec from before
> around 1.8 sec. The initial startup time is extremely important to ensure
> the screen is properly locked when going to suspend.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.cpp \
> b500ba44c2b483d7372ca46840152c90ef5f798c \
> lookandfeel/contents/lockscreen/ChangeSession.qml PRE-CREATION \
> lookandfeel/contents/lockscreen/LockOsd.qml PRE-CREATION \
> lookandfeel/contents/lockscreen/LockScreen.qml \
> 4ce9a001efc2ffab2d78388e3a619d0de93f1758 \
> lookandfeel/contents/lockscreen/MainBlock.qml PRE-CREATION
> Diff: https://git.reviewboard.kde.org/r/124933/diff/
>
>
> Testing
> -------
>
> the OSD is not anchored correctly any more.
>
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============6427763603900644695==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124933/">https://git.reviewboard.kde.org/r/124933/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 26th, 2015, 8:51 p.m. CEST, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Just place the</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div \
class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">anchors \
{ horizontalCenter: parent.horizontalCenter
bottom: parent.bottom
}
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">into the Loader to ensure the OSD is correctly \
positioned. I think the OSD should be loaded on demand, the first time it's to be \
shown.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also, Loader has an active property you can set to \
false and then set to true when you want the item to load. This way you can have the \
Loader's source where it belongs.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks. Completely delaying the OSD seems to be not practicle as the \
greeterApp looks for the osd object and does not trigger the osd if there is no such \
object. Thus the object must exist before the OSD is activated.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On August 27th, 2015, 8:36 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2015, 8:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes type errors shown on startup:
TypeError: Cannot read property 'showPassword' of undefined
TypeError: Cannot read property 'ButtonLabel' of undefined
REVIEW: 124931
[screenlocker] Try to load faster by using more loaders
All UI is put into a loader to get the actual lock screen loaded faster.
This gets the creation of two views down to about < 600 msec from before
around 1.8 sec. The initial startup time is extremely important to ensure
the screen is properly locked when going to suspend.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">the OSD is not anchored correctly any more.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(b500ba44c2b483d7372ca46840152c90ef5f798c)</span></li>
<li>lookandfeel/contents/lockscreen/ChangeSession.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeel/contents/lockscreen/LockOsd.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: \
grey">(4ce9a001efc2ffab2d78388e3a619d0de93f1758)</span></li>
<li>lookandfeel/contents/lockscreen/MainBlock.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124933/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6427763603900644695==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic