'Re: Review Request 124917: [screenlocker] Start grace time when the greeter is shown'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124917: [screenlocker] Start grace time when the greeter is shown
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-08-26 8:35:29
Message-ID: 20150826083529.21212.33566 () mimi ! kde ! org
[Download RAW message or body]

--===============3410176287985998067==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124917/#review84396
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On Aug. 25, 2015, 10:53 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124917/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2015, 10:53 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> So far the grace time started with the idle timeout. Given that our
> greeter takes a few seconds to start it rendered a short grace time
> useless as it was quite likely that the grace time already ended when
> the first visible feedback was shown to the user.
> 
> Now the grace time starts when the greeter is actually shown.
> 
> 
> Diffs
> -----
> 
> ksmserver/screenlocker/ksldapp.cpp d0636b8785101cb9896cea6399952dac0e4cd227 
> 
> Diff: https://git.reviewboard.kde.org/r/124917/diff/
> 
> 
> Testing
> -------
> 
> * grace time of 5 sec: waited for the lock screen to show, counted to 4, moved \
>                 mouse -> unlocked
> * waited till the lock screen was shown and a few minutes more, moved mouse -> no \
> unlock 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

--===============3410176287985998067==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124917/">https://git.reviewboard.kde.org/r/124917/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On August 25th, 2015, 10:53 a.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 25, 2015, 10:53 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">So far the grace time started with the idle timeout. Given that our \
greeter takes a few seconds to start it rendered a short grace time useless as it was \
quite likely that the grace time already ended when the first visible feedback was \
shown to the user.

Now the grace time starts when the greeter is actually shown.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">grace time of 5 sec: \
waited for the lock screen to show, counted to 4, moved mouse -&gt; unlocked</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">waited till the lock screen was shown and a few minutes more, moved mouse \
-&gt; no unlock</li> </ul></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(d0636b8785101cb9896cea6399952dac0e4cd227)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124917/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3410176287985998067==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 