[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124509: Use small button for session combo
From: "Thomas Pfeiffer" <colomar () autistici ! org>
Date: 2015-08-13 21:13:49
Message-ID: 20150813211349.3671.90522 () mimi ! kde ! org
[Download RAW message or body]
--===============2449432190271269403==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 4, 2015, 12:22 a.m., Thomas Pfeiffer wrote:
> > Thanks for taking this up so fast!
> > Let me check back with our icon designers regarding whether this is the best icon \
> > for that button (it always looked more like a settings icon than a menu icon to \
> > me). Otherwise, the button seems fine. I assume the fact that in the screenshot, \
> > the height of the edit box and the login button are different is unrelated tot \
> > his patch, right?
>
> Kai Uwe Broulik wrote:
> Yes, that is unrelated but I think I should fix that too. Though it's probably just \
> in test mode that the difference is as significant as in the screen shot.
Please use the toolbar/application-menu icon for the button.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124509/#review83406
-----------------------------------------------------------
On Aug. 13, 2015, 8:09 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124509/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 8:09 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> As discussed with the VDG since it's a more of a power user feature
>
>
> Diffs
> -----
>
> lookandfeel/contents/loginmanager/Main.qml 065a115
>
> Diff: https://git.reviewboard.kde.org/r/124509/diff/
>
>
> Testing
> -------
>
> Work, I had to employ a hack to make the button stay square, and also ComboBox \
> doesn't have a public API to open the popup. I tried using Plasma Menu but it \
> doesn't support exclusive group and the QQC Menu cannot be told where it should \
> open other than the mouse position (also why is the text field not the same height \
> as the login button?)
>
> File Attachments
> ----------------
>
> Login screen
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============2449432190271269403==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124509/">https://git.reviewboard.kde.org/r/124509/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 4th, 2015, 12:22 a.m. UTC, <b>Thomas \
Pfeiffer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks for taking this up so fast! Let me check back \
with our icon designers regarding whether this is the best icon for that button (it \
always looked more like a settings icon than a menu icon to me). Otherwise, the \
button seems fine. I assume the fact that in the screenshot, the height of the edit \
box and the login button are different is unrelated tot his patch, right?</p></pre> \
</blockquote>
<p>On August 4th, 2015, 10:42 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
that is unrelated but I think I should fix that too. Though it's probably just in \
test mode that the difference is as significant as in the screen shot.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please use the toolbar/application-menu icon for the button.</p></pre> <br \
/>
<p>- Thomas</p>
<br />
<p>On August 13th, 2015, 8:09 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2015, 8:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed with the VDG since it's a more of a power \
user feature</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Work, I had to employ a hack to make the button stay \
square, and also ComboBox doesn't have a public API to open the popup. I tried using \
Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told \
where it should open other than the mouse position (also why is the text field not \
the same height as the login button?)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/loginmanager/Main.qml <span style="color: \
grey">(065a115)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124509/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png">Login \
screen</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2449432190271269403==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic