[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124469: ConsoleKit2 support for screenlocker
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-08-10 14:12:13
Message-ID: 20150810141213.13071.33996 () mimi ! kde ! org
[Download RAW message or body]
--===============1794024997211387259==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124469/#review83659
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Aug. 10, 2015, 1:59 p.m., Eric Koegel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124469/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2015, 1:59 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> ConsoleKit2 has the same API as systemd-logind for Lock, Unlock,
> PrepareForSleep, and Inhibit. This patch adds the functionality
> for ConsoleKit2 while attempting to minimize code duplication.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/logind.h 9983673
> ksmserver/screenlocker/logind.cpp 5335b15
>
> Diff: https://git.reviewboard.kde.org/r/124469/diff/
>
>
> Testing
> -------
>
> dbus-send --system --dest=org.freedesktop.ConsoleKit --type=method_call \
> --print-reply --reply-timeout=2000 /org/freedesktop/ConsoleKit/Manager \
> org.freedesktop.ConsoleKit.Manager.ListInhibitors method return sender=:1.1 -> \
> dest=:1.80 reply_serial=2 array [
> struct {
> string "suspend"
> string "NetworkManager"
> string "NetworkManager needs to turn off networks"
> string "delay"
> uint32 0
> uint32 3473
> }
> struct {
> string "handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch"
> string "PowerDevil"
> string "KDE handles power events"
> string "block"
> uint32 1000
> uint32 9587
> }
> struct {
> string "suspend"
> string "Screen Locker"
> string "Ensuring that the screen gets locked before going to sleep"
> string "delay"
> uint32 1000
> uint32 9508
> }
> ]
>
> Verified ConsoleKit2 does delay suspending until both delay locks are removed.
>
>
> Thanks,
>
> Eric Koegel
>
>
--===============1794024997211387259==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124469/">https://git.reviewboard.kde.org/r/124469/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- David Edmundson</p>
<br />
<p>On August 10th, 2015, 1:59 p.m. UTC, Eric Koegel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Eric Koegel.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2015, 1:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ConsoleKit2 has the same API as systemd-logind for \
Lock, Unlock, PrepareForSleep, and Inhibit. This patch adds the functionality
for ConsoleKit2 while attempting to minimize code duplication.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">dbus-send --system --dest=org.freedesktop.ConsoleKit \
--type=method_call --print-reply --reply-timeout=2000 \
/org/freedesktop/ConsoleKit/Manager \
org.freedesktop.ConsoleKit.Manager.ListInhibitors method return sender=:1.1 -> \
dest=:1.80 reply_serial=2 array [
struct {
string "suspend"
string "NetworkManager"
string "NetworkManager needs to turn off networks"
string "delay"
uint32 0
uint32 3473
}
struct {
string "handle-power-key:handle-suspend-key:handle-hibernate-key:handle-lid-switch"
string "PowerDevil"
string "KDE handles power events"
string "block"
uint32 1000
uint32 9587
}
struct {
string "suspend"
string "Screen Locker"
string "Ensuring that the screen gets locked before going to sleep"
string "delay"
uint32 1000
uint32 9508
}
]</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Verified ConsoleKit2 does delay suspending until both \
delay locks are removed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/logind.h <span style="color: grey">(9983673)</span></li>
<li>ksmserver/screenlocker/logind.cpp <span style="color: \
grey">(5335b15)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124469/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1794024997211387259==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic