'Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabl'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabl
From:       "Gregor Mi" <codestruct () posteo ! org>
Date:       2015-08-09 19:13:52
Message-ID: 20150809191352.13071.5181 () mimi ! kde ! org
[Download RAW message or body]

--===============7785518264701458597==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Aug. 9, 2015, 6:18 p.m., David Edmundson wrote:
> > We are not shipping commented out code. 
> > 
> > The obvious side effect is that people can't see which apps are disabled, which \
> > is why this code exists. 
> > I will re-poke the VDG for comments, as they don't seem to have responded on the \
> > bug report yet.

Thanks for having a look. I am curious, is there a difference between a "disabled" \
app and a minimized one? If yes, how can I disable an app?

- Gregor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/#review83621
-----------------------------------------------------------

On Aug. 9, 2015, 7:06 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124675/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 7:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 311991
> https://bugs.kde.org/show_bug.cgi?id=311991
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This fixes Bug 311991. Though I am not sure if there are side effects which I am \
> not aware of. 
> 
> Diffs
> -----
> 
> applets/taskmanager/package/contents/ui/Task.qml \
> f655801ab1f7b1a9a915f35149c858f0ede22a29  
> Diff: https://git.reviewboard.kde.org/r/124675/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
> 

--===============7785518264701458597==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124675/">https://git.reviewboard.kde.org/r/124675/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On August 9th, 2015, 6:18 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We are not shipping commented out code. </p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">The obvious side effect is that people can't see which apps are disabled, \
which is why this code exists.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I will re-poke the VDG \
for comments, as they don't seem to have responded on the bug report yet.</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thanks for having a look. I am curious, is there a difference between a \
"disabled" app and a minimized one? If yes, how can I disable an app?</p></pre> <br \
/>

<p>- Gregor</p>

<br />
<p>On August 9th, 2015, 7:06 p.m. UTC, Gregor Mi wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Gregor Mi.</div>

<p style="color: grey;"><i>Updated Aug. 9, 2015, 7:06 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=311991">311991</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This fixes Bug 311991. Though I am not sure if there \
are side effects which I am not aware of.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(f655801ab1f7b1a9a915f35149c858f0ede22a29)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124675/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7785518264701458597==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 