'Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124668: Re-render 5.4 wallpapers with 4x antialiasing and a split noise, compress
From:       "Ben Cooksley" <bcooksley () kde ! org>
Date:       2015-08-09 8:04:51
Message-ID: 20150809080451.13071.69375 () mimi ! kde ! org
[Download RAW message or body]

--===============3930154949976223958==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124668/#review83594
-----------------------------------------------------------

I've now corrected the issue with Reviewboard - for some reason the permissions \
weren't marked properly so Apache was rightly denying access to the file(s). I \
suspect Reviewboard fell over part way through processing your upload, so it never \
got to change the permissions on the original files.

- Ben Cooksley

On Aug. 9, 2015, 7:23 a.m., Nikita Skovoroda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124668/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2015, 7:23 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Klapetek.
> 
> 
> Description
> -------
> 
> Atm, 5.4 wallpapers have pixelated lines and blurred noise (the same as \
> [https://bugs.kde.org/show_bug.cgi?id=346018](https://bugs.kde.org/show_bug.cgi?id=346018) \
> for 5.3). 
> I re-rendered them using the same script (4x supersample antialiasing and split \
> noise). 
> Split noise means that the noise pattern is not scaled for the different resolution \
> wallpapers (which looked bad on both too low and too high resolutions), but is \
> post-applied and tiled. 
> I uploaded the renders and the patch against the 'breeze' repo to \
> [http://oserv.org/files/kde/wallpaper-horizon/](http://oserv.org/files/kde/wallpaper-horizon/) \
>  
> Also there is an updated version of the script (render.sh), but the only difference \
> from the previous version is that I added some more comments at the top. 
> When reviewing, everything should be viewed at 1:1 scale.
> 
> I also uploaded a separate patch to add a 1366x768 resolution wallpaper, it's \
> (sadly) still rather popular and not covered by any of the existing resolutions \
> without downscaling or cropping from both edges. 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/124668/diff/
> 
> 
> Testing
> -------
> 
> Just opened the wallpapers at 1:1 scale and compared them.
> Also I put the corresponding resolution version as my current wallpaper =).
> 
> 
> File Attachments
> ----------------
> 
> 1024x768 before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/759129c3-b0c6-40a4-96a2-45489899c0cd__1024x768.png
>  1024x768 after
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/0800d133-08a1-4599-9942-25e3762c5ab0__1024x768.png
>  3200x2000 before (top-left part)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/95c0b177-209f-4fe6-a1c8-ead02199f32d__3200x2000-topleft-before.png
>  3200x2000 after (top-left part)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/61e34da3-b9eb-4a88-b2b7-455bf3dcc322__3200x2000-topleft-after.png
>  
> 
> Thanks,
> 
> Nikita Skovoroda
> 
> 

--===============3930154949976223958==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124668/">https://git.reviewboard.kde.org/r/124668/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've \
now corrected the issue with Reviewboard - for some reason the permissions weren't \
marked properly so Apache was rightly denying access to the file(s). I suspect \
Reviewboard fell over part way through processing your upload, so it never got to \
change the permissions on the original files.</p></pre>  <br />

<p>- Ben Cooksley</p>

<br />
<p>On August 9th, 2015, 7:23 a.m. UTC, Nikita Skovoroda wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, David Edmundson and Martin Klapetek.</div>
<div>By Nikita Skovoroda.</div>

<p style="color: grey;"><i>Updated Aug. 9, 2015, 7:23 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Atm, 5.4 wallpapers have pixelated lines and blurred \
noise (the same as <a href="https://bugs.kde.org/show_bug.cgi?id=346018" \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">https://bugs.kde.org/show_bug.cgi?id=346018</a> for 5.3).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I re-rendered them using the same script (4x supersample antialiasing and \
split noise).</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Split noise means that the noise pattern is not scaled \
for the different resolution wallpapers (which looked bad on both too low and too \
high resolutions), but is post-applied and tiled.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
uploaded the renders and the patch against the 'breeze' repo to <a \
href="http://oserv.org/files/kde/wallpaper-horizon/" style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">http://oserv.org/files/kde/wallpaper-horizon/</a> </p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also \
there is an updated version of the script (render.sh), but the only difference from \
the previous version is that I added some more comments at the top.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">When reviewing, everything should be viewed at 1:1 scale.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I also uploaded a separate patch to add a 1366x768 resolution wallpaper, \
it's (sadly) still rather popular and not covered by any of the existing resolutions \
without downscaling or cropping from both edges.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Just opened the wallpapers at 1:1 scale and compared \
them. Also I put the corresponding resolution version as my current wallpaper \
=).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124668/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/759129c3-b0c6-40a4-96a2-45489899c0cd__1024x768.png">1024x768 \
before</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/0800d133-08a1-4599-9942-25e3762c5ab0__1024x768.png">1024x768 \
after</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/95c0b177-209f-4fe6-a1c8-ead02199f32d__3200x2000-topleft-before.png">3200x2000 \
before (top-left part)</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/09/61e34da3-b9eb-4a88-b2b7-455bf3dcc322__3200x2000-topleft-after.png">3200x2000 \
after (top-left part)</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3930154949976223958==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 