'Re: Review Request 123877: [digital-clock] Bring back font family option'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123877: [digital-clock] Bring back font family option
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-08-03 18:12:23
Message-ID: 20150803181223.11735.4751 () mimi ! kde ! org
[Download RAW message or body]

--===============4560473115105515663==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123877/
-----------------------------------------------------------

(Updated Aug. 3, 2015, 6:12 nachm.)

Review request for Plasma and KDE Usability.

Summary (updated)
-----------------

[digital-clock] Bring back font family option

Bugs: 348072
    https://bugs.kde.org/show_bug.cgi?id=348072

Repository: plasma-workspace

Description (updated)
-------

This restores the custom font family option; also clean ups the layout a bit - we \
don't have a FormLayout, so that's the best it can get. Did I mention dealing with \
ComboBox is horrible?

Diffs (updated)
-----

  applets/digital-clock/package/contents/config/main.xml 8b0872b 
  applets/digital-clock/package/contents/ui/DigitalClock.qml 696903a 
  applets/digital-clock/package/contents/ui/configAppearance.qml cc1acbe 

Diff: https://git.reviewboard.kde.org/r/123877/diff/

Testing (updated)
-------

The "Default" font option restores the default font, options in the dialog are \
properly restored when it opens, Apply button does not appear to have become broken.

File Attachments
----------------

The clock
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png
 Settings
  https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png

Thanks,

Kai Uwe Broulik

--===============4560473115105515663==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123877/">https://git.reviewboard.kde.org/r/123877/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Aug. 3, 2015, 6:12 nachm.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[digital-clock] Bring back font family option</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=348072">348072</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This restores the custom font family option; also \
clean ups the layout a bit - we don't have a FormLayout, so that's the best it can \
get. Did I mention dealing with ComboBox is horrible?</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The "Default" font option restores the default font, \
options in the dialog are properly restored when it opens, Apply button does not \
appear to have become broken.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/digital-clock/package/contents/config/main.xml <span style="color: \
grey">(8b0872b)</span></li>

 <li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(696903a)</span></li>

 <li>applets/digital-clock/package/contents/ui/configAppearance.qml <span \
style="color: grey">(cc1acbe)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123877/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png">The \
clock</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png">Settings</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4560473115105515663==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 