[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124509: Use small button for session combo
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-08-01 14:25:43
Message-ID: 20150801142543.31864.99194 () mimi ! kde ! org
[Download RAW message or body]
--===============2031992857285388710==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Aug. 1, 2015, 12:11 vorm., David Edmundson wrote:
> > lookandfeel/contents/loginmanager/Main.qml, line 187
> > <https://git.reviewboard.kde.org/r/124509/diff/2/?file=388547#file388547line187>
> >
> > I can see why you did this, but if we're having to hack round our own features \
> > then we clearly have a problem.
Probably ToolButton needs a "round" property where you can tell it not to become \
round
> On Aug. 1, 2015, 12:11 vorm., David Edmundson wrote:
> > lookandfeel/contents/loginmanager/Main.qml, line 209
> > <https://git.reviewboard.kde.org/r/124509/diff/2/?file=388547#file388547line209>
> >
> > this seems a bit odd; should we just use a context menu?
> >
> > I think we can use the menu property on the button and put the model items as \
> > entries in a Repeater
I didn't know that. I wanted to use the QQC Menu because it supports exclusiveGroup \
but I couldn't pop it up at an arbitrary position, so with "menu" should work.
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124509/#review83144
-----------------------------------------------------------
On Juli 29, 2015, 10:58 vorm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124509/
> -----------------------------------------------------------
>
> (Updated Juli 29, 2015, 10:58 vorm.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> As discussed with the VDG since it's a more of a power user feature
>
>
> Diffs
> -----
>
> lookandfeel/contents/loginmanager/Main.qml 065a115
>
> Diff: https://git.reviewboard.kde.org/r/124509/diff/
>
>
> Testing
> -------
>
> Work, I had to employ a hack to make the button stay square, and also ComboBox \
> doesn't have a public API to open the popup. I tried using Plasma Menu but it \
> doesn't support exclusive group and the QQC Menu cannot be told where it should \
> open other than the mouse position (also why is the text field not the same height \
> as the login button?)
>
> File Attachments
> ----------------
>
> Login screen
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============2031992857285388710==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124509/">https://git.reviewboard.kde.org/r/124509/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 1st, 2015, 12:11 vorm. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124509/diff/2/?file=388547#file388547line187" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lookandfeel/contents/loginmanager/Main.qml</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">187</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="c1">// HACK prevent the ToolButton from turning round, it won't when \
it finds</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can see why you did \
this, but if we're having to hack round our own features then we clearly have a \
problem.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Probably ToolButton needs a "round" property where you can tell it not to \
become round</p></pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 1st, 2015, 12:11 vorm. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124509/diff/2/?file=388547#file388547line209" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lookandfeel/contents/loginmanager/Main.qml</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">208</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">visible:</span> <span class="kc">false</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
seems a bit odd; should we just use a context menu?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think we can use the menu property on the button and put the model items as entries \
in a Repeater</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I didn't know that. I wanted to use the QQC Menu because it supports \
exclusiveGroup but I couldn't pop it up at an arbitrary position, so with "menu" \
should work.</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Juli 29th, 2015, 10:58 vorm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Juli 29, 2015, 10:58 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed with the VDG since it's a more of a power \
user feature</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Work, I had to employ a hack to make the button stay \
square, and also ComboBox doesn't have a public API to open the popup. I tried using \
Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told \
where it should open other than the mouse position (also why is the text field not \
the same height as the login button?)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/loginmanager/Main.qml <span style="color: \
grey">(065a115)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124509/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png">Login \
screen</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2031992857285388710==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic