'Re: Review Request 124547: Use the same behavior of MouseArea to map coords of filtered child events'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124547: Use the same behavior of MouseArea to map coords of filtered child events
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-07-31 15:16:08
Message-ID: 20150731151608.31864.33515 () mimi ! kde ! org
[Download RAW message or body]

--===============4235344821933614940==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124547/
-----------------------------------------------------------

(Updated July 31, 2015, 3:16 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: kdeclarative

Description
-------

filtered mouse events and mouse events will have coordinates mapped differently, \
having a touch and a mouse click on the same place arriving with two different \
coordinates in the event filter. for more details see \
https://bugreports.qt.io/browse/QTBUG-46761 \
https://codereview.qt-project.org/#/c/114424/ It's unlikely this behavior to change \
in Qt as a change may have strange sideeffects in current user code.

What we would want is coordinates arriving all mapped as they were local coordinates \
of the MouseEventListener. This makes it do like MouseArea, that maps from \
event->windowPos() , making it actually bypassing the wrong pos() of the filtered \
event.

The behavior for mouse clicks should be completely the same, but this should fix \
touch event coordinates.

Diffs
-----

  src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp ffbaf42 

Diff: https://git.reviewboard.kde.org/r/124547/diff/

Testing
-------

Thanks,

Marco Martin

--===============4235344821933614940==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124547/">https://git.reviewboard.kde.org/r/124547/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated July 31, 2015, 3:16 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">filtered mouse events and mouse events will have \
coordinates mapped differently, having a touch and a mouse click on the same place \
arriving with two different coordinates in the event filter. for more details see \
https://bugreports.qt.io/browse/QTBUG-46761 \
https://codereview.qt-project.org/#/c/114424/ It's unlikely this behavior to change \
in Qt as a change may have strange sideeffects in current user code.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What we would want is coordinates arriving all mapped as they were local \
coordinates of the MouseEventListener. This makes it do like MouseArea, that maps \
from event-&gt;windowPos() , making it actually bypassing the wrong pos() of the \
filtered event.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The behavior for mouse clicks should be \
completely the same, but this should fix touch event coordinates.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp <span style="color: \
grey">(ffbaf42)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124547/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4235344821933614940==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 