'Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the K'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the K
From:       "David Faure" <faure () kde ! org>
Date:       2015-07-31 13:52:08
Message-ID: 20150731135208.31864.1993 () mimi ! kde ! org
[Download RAW message or body]

--===============1180287323592284506==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124534/
-----------------------------------------------------------

(Updated July 31, 2015, 1:52 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Vishesh Handa.

Changes
-------

Submitted with commit e33b582fda5588762aa50e3ad619283b97e7d758 by David Faure to \
branch master.

Repository: plasma-workspace

Description
-------

Commit f913e251fe6 removed this, due to a porting bug: both klauncher
(XDG autostart using .desktop files) and ksmserver (kde-specific scripts)
were ported to look at the same directory (~/.config/autostart),
leading to double autostart. The right fix, however, is to use
a different directory for scripts, I called it ~/.config/autostart-scripts.

BUG: 338242
REVIEW: 124534

Diffs
-----

  ksmserver/server.h 2176aa1c9a6505773b61354dee6fd547fdf5841e 
  ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524 

Diff: https://git.reviewboard.kde.org/r/124534/diff/

Testing
-------

Logged out and back in many times :)

My autostart folder got copied correctly, including symlinks

Thanks,

David Faure

--===============1180287323592284506==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124534/">https://git.reviewboard.kde.org/r/124534/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Vishesh Handa.</div>
<div>By David Faure.</div>

<p style="color: grey;"><i>Updated July 31, 2015, 1:52 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit e33b582fda5588762aa50e3ad619283b97e7d758 by David \
Faure to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Commit f913e251fe6 removed this, due to a porting bug: both klauncher \
(XDG autostart using .desktop files) and ksmserver (kde-specific scripts) were ported \
to look at the same directory (~/.config/autostart), leading to double autostart. The \
right fix, however, is to use a different directory for scripts, I called it \
~/.config/autostart-scripts.

BUG: 338242
REVIEW: 124534</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Logged out and back in many times :)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">My autostart folder got copied correctly, including symlinks</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/server.h <span style="color: \
grey">(2176aa1c9a6505773b61354dee6fd547fdf5841e)</span></li>

 <li>ksmserver/startup.cpp <span style="color: \
grey">(531e88b4257901e890f16c23761d2c0aa538d524)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124534/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1180287323592284506==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 