--===============1883598020632500129== Content-Type: multipart/alternative; boundary="===============6646424233590488403==" --===============6646424233590488403== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124536/#review83232 ----------------------------------------------------------- src/kdeclarative/configpropertymap.cpp (line 76) this actually duplicates the same keys twice - Marco Martin On July 30, 2015, 8:10 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124536/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 8:10 p.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This exposes a hash of immutable config options through the "immutables" property. I tried adding a Q_INVOKABLE which would be much nicer but me and Dan tried everything but couldn't make it work. > > > Diffs > ----- > > src/kdeclarative/configpropertymap.cpp 93c49a3 > > Diff: https://git.reviewboard.kde.org/r/124536/diff/ > > > Testing > ------- > > Works, I can not grey out immutable config options in Plasma > > > Thanks, > > Kai Uwe Broulik > > --===============6646424233590488403== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124536/

src/kdeclarative/configpropertymap.cpp (Diff revision 1)
ConfigPropertyMap::~ConfigPropertyMap()
		76	if (item->isImmutable()) {

this actually duplicates the same keys twice

- Marco Martin

On July 30th, 2015, 8:10 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma.

By Kai Uwe Broulik.

Updated July 30, 2015, 8:10 p.m.

Repository: kdeclarative

Description

This exposes a hash of immutable config options through the "immutables" property. I tried adding a Q_INVOKABLE which would be much nicer but me and Dan tried everything but couldn't make it work.

Testing

Works, I can not grey out immutable config options in Plasma

Diffs

src/kdeclarative/configpropertymap.cpp (93c49a3)

View Diff

--===============6646424233590488403==-- --===============1883598020632500129== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1883598020632500129==--