'Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the K'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124534: ksmserver: restore support for autostart scripts; migrate them from the K
From:       "Mark Gaiser" <markg85 () gmail ! com>
Date:       2015-07-31 8:45:07
Message-ID: 20150731084507.31864.85153 () mimi ! kde ! org
[Download RAW message or body]

--===============8333516750156766570==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124534/#review83216
-----------------------------------------------------------

+1

I guess this code still needs to be ported to using the categorized debugging \
(qCDebug, qCWarning, etc...). Or is plasma not doing that at all? Anyway, that's out \
of scope for this rr.

- Mark Gaiser

On jul 31, 2015, 8:32 a.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124534/
> -----------------------------------------------------------
> 
> (Updated jul 31, 2015, 8:32 a.m.)
> 
> 
> Review request for Plasma and Vishesh Handa.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Commit f913e251fe6 removed this, due to a porting bug: both klauncher
> (XDG autostart using .desktop files) and ksmserver (kde-specific scripts)
> were ported to look at the same directory (~/.config/autostart),
> leading to double autostart. The right fix, however, is to use
> a different directory for scripts, I called it ~/.config/autostart-scripts.
> 
> BUG: 338242
> REVIEW: 124534
> 
> 
> Diffs
> -----
> 
> ksmserver/server.h 2176aa1c9a6505773b61354dee6fd547fdf5841e 
> ksmserver/startup.cpp 531e88b4257901e890f16c23761d2c0aa538d524 
> 
> Diff: https://git.reviewboard.kde.org/r/124534/diff/
> 
> 
> Testing
> -------
> 
> Logged out and back in many times :)
> 
> My autostart folder got copied correctly, including symlinks
> 
> 
> Thanks,
> 
> David Faure
> 
> 

--===============8333516750156766570==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124534/">https://git.reviewboard.kde.org/r/124534/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I guess this code still needs to be ported to using \
the categorized debugging (qCDebug, qCWarning, etc...). Or is plasma not doing that \
at all? Anyway, that's out of scope for this rr.</p></pre>
 <br />

<p>- Mark Gaiser</p>

<br />
<p>On juli 31st, 2015, 8:32 a.m. UTC, David Faure wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Vishesh Handa.</div>
<div>By David Faure.</div>

<p style="color: grey;"><i>Updated jul 31, 2015, 8:32 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Commit f913e251fe6 removed this, due to a porting bug: both klauncher \
(XDG autostart using .desktop files) and ksmserver (kde-specific scripts) were ported \
to look at the same directory (~/.config/autostart), leading to double autostart. The \
right fix, however, is to use a different directory for scripts, I called it \
~/.config/autostart-scripts.

BUG: 338242
REVIEW: 124534</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Logged out and back in many times :)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">My autostart folder got copied correctly, including symlinks</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/server.h <span style="color: \
grey">(2176aa1c9a6505773b61354dee6fd547fdf5841e)</span></li>

 <li>ksmserver/startup.cpp <span style="color: \
grey">(531e88b4257901e890f16c23761d2c0aa538d524)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124534/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8333516750156766570==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 