[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124397: Add today button to calendar
From: "Bernhard Friedreich" <friesoft () gmail ! com>
Date: 2015-07-29 21:33:36
Message-ID: 20150729213336.31864.90124 () mimi ! kde ! org
[Download RAW message or body]
--===============1116378042556712813==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Juli 28, 2015, 8:37 nachm., Martin Klapetek wrote:
> > src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 147-149
> > <https://git.reviewboard.kde.org/r/124397/diff/3/?file=388457#file388457line147>
> >
> > Given this is only used here, would it make more sense to actually move the \
> > function here? Having it on the main item does not seem to bring any \
> > advantages...
resetToday in MonthView.qml is used for example by \
org.kde.plasma.digitalclock/contents/ui/CalendarView.qml
I don't know where else it is also used..
- Bernhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review83118
-----------------------------------------------------------
On Juli 28, 2015, 8:32 nachm., Bernhard Friedreich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124397/
> -----------------------------------------------------------
>
> (Updated Juli 28, 2015, 8:32 nachm.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Bugs: 348362
> http://bugs.kde.org/show_bug.cgi?id=348362
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Add button "Select Today" to calendar title bar
>
> BUG: 348362
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/qml/DaysCalendar.qml \
> 35a1e202ced1c050479ed04d71d8976a4e03a12c
> Diff: https://git.reviewboard.kde.org/r/124397/diff/
>
>
> Testing
> -------
>
> plasmoidviewer with digitalclock plasmoid
> added digitalclock plasmoid to desktop
>
> clicked digital clock plasmoid to view calendar
> "Select Today" button is shown
> select different day
> clicked button -> selection changes to today
> moved to another month/month selection/year/year selection -> clicked button --> \
> jumps to today
>
> File Attachments
> ----------------
>
> Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
>
>
> Thanks,
>
> Bernhard Friedreich
>
>
--===============1116378042556712813==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124397/">https://git.reviewboard.kde.org/r/124397/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juli 28th, 2015, 8:37 nachm. UTC, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124397/diff/3/?file=388457#file388457line147" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/qml/DaysCalendar.qml</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">147</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">onClicked:</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">148</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">resetToToday</span><span class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">149</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given this is only used \
here, would it make more sense to actually move the function here? Having it on the \
main item does not seem to bring any advantages...</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">resetToday in MonthView.qml is used for example by \
org.kde.plasma.digitalclock/contents/ui/CalendarView.qml</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't know where else it is also used..</p></pre> <br />
<p>- Bernhard</p>
<br />
<p>On Juli 28th, 2015, 8:32 nachm. UTC, Bernhard Friedreich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Bernhard Friedreich.</div>
<p style="color: grey;"><i>Updated Juli 28, 2015, 8:32 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=348362">348362</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add button "Select Today" to calendar title bar</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">BUG: 348362</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasmoidviewer with digitalclock plasmoid added \
digitalclock plasmoid to desktop</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">clicked digital clock \
plasmoid to view calendar "Select Today" button is shown
select different day
clicked button -> selection changes to today
moved to another month/month selection/year/year selection -> clicked button \
--> jumps to today</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(35a1e202ced1c050479ed04d71d8976a4e03a12c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124397/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png">Plasmoidviewer \
Digital Clock showing Calendar with Today ToolButton</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1116378042556712813==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic