[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: AccountsService qt binding for sddm, plasma-workspace screenlocker greeter and plasma-desktop ki
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2015-07-29 9:02:03
Message-ID: CAGeFrHBzm6Qtd43kg7Ky8wr+BuNMeQGgU71ES1J=Z1-4WGH8hw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hey, sorry for not replying.

5.4 is being frozen soon, so lets consider this 5.5 material, so we don't
have to rush.

In general, I like it, I have some comments.

I'm a bit concerned by the blocking calls in AccountsService here:
https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107


That has the potential to lock up the entire plasma workspace session;
which obviously isn't ideal.
Blocking calls are a problem if we can't rely on the remote service
/always/ behaving.

--

In here:
http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=3fa23fc71131c239201bec7e7 \
841455d3c5e5a2c&hp=b500ba44c2b483d7372ca46840152c90ef5f798c&hb=1f308546910b1e3e63542bb1982778755e8ff99d&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp


we're using QtAccounts for the icon, but KUser for the name. That's a bit
weird.

--

What's this for:
http://quickgit.kde.org/?p=plasma-workspace.git&a=blobdiff&h=a4888cef5415d09e36f594080 \
e4f1d1103b896ec&hp=3fa23fc71131c239201bec7e7841455d3c5e5a2c&hb=58091b95fae55fcc96e95a28599df05130a64bb6&f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp


AccountsService will also search ~/.face.icon, so I can't imagine this
doing anything.

---

We have some code in KDeclarative that returns a user, wrapping kuser. I
don't want to have code in our lib that does one thing, and have our shell
code doing another.


David


[Attachment #5 (text/html)]

<div dir="ltr"><div><div></div>Hey, sorry for not replying.<br><br></div><div>5.4 is \
being frozen soon, so lets consider this 5.5 material, so we don&#39;t have to \
rush.<br><br></div><div>In general, I like it, I have some \
comments.<br></div><div><br></div><div>I&#39;m a bit concerned by the blocking calls \
in AccountsService here:<br><a \
href="https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsserv \
ice/accountsmanager.cpp#L107">https://github.com/hawaii-desktop/qtaccountsservice/blob/master/src/accountsservice/accountsmanager.cpp#L107</a><br><br></div><div>That \
has the potential to lock up the entire plasma workspace session; which obviously \
isn&#39;t ideal.<br></div><div>Blocking calls are a problem if we can&#39;t rely on \
the remote service  /always/ behaving.<br><br>--<br><br></div><div>In here: <a \
href="http://quickgit.kde.org/?p=plasma-workspace.git&amp;a=blobdiff&amp;h=3fa23fc7113 \
1c239201bec7e7841455d3c5e5a2c&amp;hp=b500ba44c2b483d7372ca46840152c90ef5f798c&amp;hb=1 \
f308546910b1e3e63542bb1982778755e8ff99d&amp;f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgre \
eterapp.cpp">http://quickgit.kde.org/?p=plasma-workspace.git&amp;a=blobdiff&amp;h=3fa2 \
3fc71131c239201bec7e7841455d3c5e5a2c&amp;hp=b500ba44c2b483d7372ca46840152c90ef5f798c&a \
mp;hb=1f308546910b1e3e63542bb1982778755e8ff99d&amp;f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp</a><br><br></div><div>we&#39;re \
using QtAccounts for the icon, but KUser for the name. That&#39;s a bit \
weird.<br><br>--<br><br></div><div>What&#39;s this for:<br><a \
href="http://quickgit.kde.org/?p=plasma-workspace.git&amp;a=blobdiff&amp;h=a4888cef541 \
5d09e36f594080e4f1d1103b896ec&amp;hp=3fa23fc71131c239201bec7e7841455d3c5e5a2c&amp;hb=5 \
8091b95fae55fcc96e95a28599df05130a64bb6&amp;f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgre \
eterapp.cpp">http://quickgit.kde.org/?p=plasma-workspace.git&amp;a=blobdiff&amp;h=a488 \
8cef5415d09e36f594080e4f1d1103b896ec&amp;hp=3fa23fc71131c239201bec7e7841455d3c5e5a2c&a \
mp;hb=58091b95fae55fcc96e95a28599df05130a64bb6&amp;f=ksmserver%2Fscreenlocker%2Fgreeter%2Fgreeterapp.cpp</a><br><br></div><div>AccountsService \
will also search ~/.face.icon, so I can&#39;t imagine this doing \
anything.<br><br>---<br><br></div><div>We have some code in KDeclarative that returns \
a user, wrapping kuser. I don&#39;t want to have code in our lib that does one thing, \
and have our shell code doing another.<br><br><br></div><div>David<br></div></div>


[Attachment #6 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]