From kde-panel-devel Wed Jul 29 08:59:18 2015 From: "Kai Uwe Broulik" Date: Wed, 29 Jul 2015 08:59:18 +0000 To: kde-panel-devel Subject: Re: Review Request 123889: [krunner] Add button to clear history Message-Id: <20150729085918.4444.14796 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143816037309453 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1940273780678878883==" --===============1940273780678878883== Content-Type: multipart/alternative; boundary="===============5342500606627401422==" --===============5342500606627401422== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123889/ ----------------------------------------------------------- (Updated July 29, 2015, 8:59 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma, KDE Usability and Vishesh Handa. Changes ------- Submitted with commit 703e9b113c07c447d7d4e3d65c7216627af4865a by Kai Uwe Broulik to branch master. Bugs: 275645? https://bugs.kde.org/show_bug.cgi?id=275645? Repository: plasma-desktop Description ------- This adds a "Clear history" button to the plasmasearch kcm to clear the history. Diffs ----- kcms/runners/kcm.cpp 10b7683 Diff: https://git.reviewboard.kde.org/r/123889/diff/ Testing ------- Clicked button, history gone, popup updated automatically. Could perhaps check whether the history is currently empty and be disabled in that case? Dunno if adding a file watcher to track live changes is worth it though. File Attachments ---------------- Button in KCM https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/c86950ed-04ca-4d3d-8697-a13c21b47ad6__krunnerclearhistory.png Thanks, Kai Uwe Broulik --===============5342500606627401422== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123889/

This change has been marked as submitted.

Review request for Plasma, KDE Usability and Vishesh Handa.

By Kai Uwe Broulik.

Updated July 29, 2015, 8:59 a.m.

Changes

Submitted with commit 703e9b113c07c447d7d4e3d65c7216627af4865a by Kai Uwe Broulik to branch master.

Bugs: 275645?

Repository: plasma-desktop

Description

This adds a "Clear history" button to the plasmasearch kcm to clear the history.

Testing

Clicked button, history gone, popup updated automatically. Could perhaps check whether the history is currently empty and be disabled in that case? Dunno if adding a file watcher to track live changes is worth it though.

Diffs

kcms/runners/kcm.cpp (10b7683)

View Diff

File Attachments

Button in KCM

--===============5342500606627401422==-- --===============1940273780678878883== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1940273780678878883==--