[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Notes from Plasma BoF
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2015-07-29 0:16:18
Message-ID: CAGeFrHDijF677a41+jXCHD8WVZ6M3EiuGOnqfmVfR8KPsuUi8w () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Wed, Jul 29, 2015 at 12:35 AM, Eike Hein <hein@kde.org> wrote:
>
>
> On 07/28/2015 04:42 PM, David Edmundson wrote:
> > Lets make sure we go through reviews please.
>
> Sure. The preliminary code is in the hein/appdash branches
> of plasma-desktop and kdeplasma-addons (you need both), and
> it's called "Application Dashboard" in the widget list.
>
> Cool, ship it.
Two things to fixup.
+void FullScreenWindow::updateTheme()
half the code here is never executed
+ const QChar &first = appEntry->name().at(0).toUpper();
QString::at() will qFatal() if out of bounds ;
it's not unfeasible to have a dodgy .desktop entry without a name.
> The various notes on this Marco and you got in IRC discussions
> etc. apply :)
>
> There's a few remaining issues I still need to address, in
> particular mouse wheel support for complex categorized views.
>
>
> Cheers,
> Eike
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
[Attachment #5 (text/html)]
<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul \
29, 2015 at 12:35 AM, Eike Hein <span dir="ltr"><<a href="mailto:hein@kde.org" \
target="_blank">hein@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span \
class=""><br> <br>
On 07/28/2015 04:42 PM, David Edmundson wrote:<br>
> Lets make sure we go through reviews please.<br>
<br>
</span>Sure. The preliminary code is in the hein/appdash branches<br>
of plasma-desktop and kdeplasma-addons (you need both), and<br>
it's called "Application Dashboard" in the widget list.<br>
<br></blockquote><div>Cool, ship it.<br></div><div><br></div><div>Two things to \
fixup.<br></div><div><br>+void FullScreenWindow::updateTheme()<br><br>half the code \
here is never executed<br><br><br><br><br>+ const QChar \
&first = appEntry->name().at(0).toUpper();<br><br>QString::at() will qFatal() \
if out of bounds ; <br>it's not unfeasible to have a dodgy .desktop entry without \
a name.<br><br><br><br><br><br><br> </div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> The various \
notes on this Marco and you got in IRC discussions<br> etc. apply :)<br>
<br>
There's a few remaining issues I still need to address, in<br>
particular mouse wheel support for complex categorized views.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
Cheers,<br>
Eike<br>
_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" rel="noreferrer" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
</div></div></blockquote></div><br></div></div>
[Attachment #6 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic