[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124507: Pinch to zoom out in the calendar
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-07-28 15:34:13
Message-ID: 20150728153413.21923.45893 () mimi ! kde ! org
[Download RAW message or body]
--===============7446179406796583299==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 28, 2015, 12:41 p.m., David Edmundson wrote:
> > src/declarativeimports/calendar/qml/DaysCalendar.qml, line 70
> > <https://git.reviewboard.kde.org/r/124507/diff/1/?file=388382#file388382line70>
> >
> > should scaleBehaviorEnabled be reset here?
maybe, but in that case it should happen after the behavior animation finished?
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124507/#review83088
-----------------------------------------------------------
On July 28, 2015, 12:23 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124507/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 12:23 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Now you can pinch to zoom out in the calendar. Why? Because we can!
>
> https://www.youtube.com/watch?v=i8a-MPyzMOw
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e20
> src/declarativeimports/calendar/qml/MonthView.qml 57ac59a
>
> Diff: https://git.reviewboard.kde.org/r/124507/diff/
>
>
> Testing
> -------
>
> Works.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============7446179406796583299==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124507/">https://git.reviewboard.kde.org/r/124507/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 28th, 2015, 12:41 p.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124507/diff/1/?file=388382#file388382line70" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/calendar/qml/DaysCalendar.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">70</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="nx">scale</span> <span class="o">=</span> <span \
class="mi">1</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">should scaleBehaviorEnabled be reset here?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">maybe, but in that case it should happen after the behavior animation \
finished?</p></pre> <br />
<p>- Marco</p>
<br />
<p>On July 28th, 2015, 12:23 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated July 28, 2015, 12:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now you can pinch to zoom out in the calendar. Why? \
Because we can!</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: \
inherit;">https://www.youtube.com/watch?v=i8a-MPyzMOw</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(35a1e20)</span></li>
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(57ac59a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124507/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7446179406796583299==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic