'Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124449: [digital-clock] Introduce new layouting state for small panels
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-07-28 11:21:58
Message-ID: 20150728112158.21923.43939 () mimi ! kde ! org
[Download RAW message or body]

--===============5444170824852204573==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124449/
-----------------------------------------------------------

(Updated July 28, 2015, 1:21 p.m.)

Review request for Plasma and KDE Usability.

Changes
-------

Changed pipe Label for Rectangle; see screenshot.

Bugs: 348072
    https://bugs.kde.org/show_bug.cgi?id=348072

Repository: plasma-workspace

Description
-------

One of the most reported bugs wrt digital clock is that the second line
text (date or timezone) is unreadable on small panels so this adds new
state to the clock applet that lays things horizontally when the panel
is too small to show text with the "small" font (set in system settings).

When there is a date displayed, a delimiter is put in between to allow
easier and faster spotting the time (as on a first glance there is just
a bunch of numbers, so quickly orienteering is super important). I used
the dot symbol first but then went for pipe which I think looks more clean;
see screenshots for comparison.

I've made a quick video showing the state changes,
see https://www.youtube.com/watch?v=t7w0k8H22h4 - it shows the bullet
delimiter and a bit wrong spacing which is now fixed.

Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078 

Diff: https://git.reviewboard.kde.org/r/124449/diff/

Testing
-------

Everything works as it used and now with small panel things are layed
horizontally, see video above.

File Attachments (updated)
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/0173583e-08ec-455b-9417-42d390aac81d__clock-rect-delimiter2.png

Thanks,

Martin Klapetek

--===============5444170824852204573==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124449/">https://git.reviewboard.kde.org/r/124449/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and KDE Usability.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated July 28, 2015, 1:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed pipe Label for Rectangle; see screenshot.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=348072">348072</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">One of the most reported bugs wrt digital clock is \
that the second line text (date or timezone) is unreadable on small panels so this \
adds new state to the clock applet that lays things horizontally when the panel
is too small to show text with the "small" font (set in system settings).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When there is a date displayed, a delimiter is put in \
between to allow easier and faster spotting the time (as on a first glance there is \
just a bunch of numbers, so quickly orienteering is super important). I used
the dot symbol first but then went for pipe which I think looks more clean;
see screenshots for comparison.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've made a quick video showing the state changes, see \
https://www.youtube.com/watch?v=t7w0k8H22h4 - it shows the bullet delimiter and a bit \
wrong spacing which is now fixed.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything works as it used and now with small panel \
things are layed horizontally, see video above.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(9506078)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124449/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/0173583e-08ec-455b-9417-42d390aac81d__clock-rect-delimiter2.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5444170824852204573==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 