[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124453: [digital-clock] Provide a simple option for 24h clock
From: "Thomas Pfeiffer" <colomar () autistici ! org>
Date: 2015-07-28 0:07:15
Message-ID: 20150728000715.21960.11161 () mimi ! kde ! org
[Download RAW message or body]
--===============3263828614760884425==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 26, 2015, 12:35 a.m., Thomas Pfeiffer wrote:
> > I fully agree with you, in both that this should only be a temporary workaround, \
> > and on that it is very helpful as such. +1 from me!
>
> Martin Klapetek wrote:
> What's your take on Kai's comment about using a combobox for the options? Currently \
> it is a single checkbox, see the screenshot at [1]. I think you either want to use \
> 24h or you want to use 12h clock and I think that one does not change locales that \
> offten to warrant a "system default", a combo imho is then a needless clutter to \
> the settings dialog. Comments?
> [1] https://lh5.googleusercontent.com/-riysQFXKRfs/VbJqhhB8yBI/AAAAAAAAT4U/Zy205nGVXF0/w904-h574-no/digital-clock-5_4.png
>
I agree with Martin: Locale isn't likely to change so often, so I don't think it's \
much of an annoyance to have to adapt the setting to your liking each time you change \
the locale. I'd default it the the one the locale chooses and then allow users to \
change it manually, period.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124453/#review82967
-----------------------------------------------------------
On July 25, 2015, 9:55 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124453/
> -----------------------------------------------------------
>
> (Updated July 25, 2015, 9:55 p.m.)
>
>
> Review request for Plasma and Thomas Pfeiffer.
>
>
> Bugs: 345378
> https://bugs.kde.org/show_bug.cgi?id=345378
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This is _the_ most requested feature for the clock, simple checkbox for 24h clock.
>
> In my opinion this is just a temporary workaround and not a very good one \
> (generally, code-wise it's awesome :P). There should really be a global config \
> option for that but as we now rely on QLocale and QLocale is...bad at this, here's \
> at least this small help, which will at least change the clock format on the panel.
>
> Imo we could really really use something like KLocale again.
>
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/config/main.xml 8b0872b
> applets/digital-clock/package/contents/ui/DigitalClock.qml 9506078
> applets/digital-clock/package/contents/ui/configAppearance.qml ead0ad5
>
> Diff: https://git.reviewboard.kde.org/r/124453/diff/
>
>
> Testing
> -------
>
> Switching the checkbox on and off works as expected.
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============3263828614760884425==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124453/">https://git.reviewboard.kde.org/r/124453/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 26th, 2015, 12:35 a.m. UTC, <b>Thomas \
Pfeiffer</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I fully agree with you, in both that this should only \
be a temporary workaround, and on that it is very helpful as such. +1 from \
me!</p></pre> </blockquote>
<p>On July 27th, 2015, 10:13 a.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">What's your take on Kai's comment about using a combobox for the options? \
Currently it is a single checkbox, see the screenshot at [1]. I think you either want \
to use 24h or you want to use 12h clock and I think that one does not change locales \
that offten to warrant a "system default", a combo imho is then a needless clutter to \
the settings dialog. Comments?</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] \
https://lh5.googleusercontent.com/-riysQFXKRfs/VbJqhhB8yBI/AAAAAAAAT4U/Zy205nGVXF0/w904-h574-no/digital-clock-5_4.png</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
agree with Martin: Locale isn't likely to change so often, so I don't think it's much \
of an annoyance to have to adapt the setting to your liking each time you change the \
locale. I'd default it the the one the locale chooses and then allow users to change \
it manually, period.</p></pre> <br />
<p>- Thomas</p>
<br />
<p>On July 25th, 2015, 9:55 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Thomas Pfeiffer.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated July 25, 2015, 9:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=345378">345378</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is _the_ most requested feature for the clock, simple checkbox for \
24h clock.
In my opinion this is just a temporary workaround and not a very good one (generally,
code-wise it's awesome :P). There should really be a global config option for \
that but as we now rely on QLocale and QLocale is...bad at this, here's at least \
this small help, which will at least change the clock format on the panel.
Imo we could really really use something like KLocale again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Switching the checkbox on and off works as \
expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/config/main.xml <span style="color: \
grey">(8b0872b)</span></li>
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(9506078)</span></li>
<li>applets/digital-clock/package/contents/ui/configAppearance.qml <span \
style="color: grey">(ead0ad5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124453/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3263828614760884425==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic