[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123468: Add setting to adjust screen scaling
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-07-27 14:07:17
Message-ID: 20150727140717.21960.8281 () mimi ! kde ! org
[Download RAW message or body]
--===============5924823514760064274==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Juli 27, 2015, 10:36 vorm., Daniel Vrátil wrote:
> > Another idea: should we somehow somewhere show a message that this only applies \
> > after logout/login? Otherwise we get bugreports that it does not work :)
Yeah perhaps place a KMessageWidget at the top that says that (or the ugly dialog we \
usually use in fonts)
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123468/#review83031
-----------------------------------------------------------
On Juli 26, 2015, 2:35 nachm., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123468/
> -----------------------------------------------------------
>
> (Updated Juli 26, 2015, 2:35 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: kscreen
>
>
> Description
> -------
>
> Single dialog alters both QT_DEVICE_PIXEL_RAITO and XRDB.DPI text
> scaling factor that used to reside in fonts KCM.
>
> A preview widget shows how this will look on the that monitor.
>
> Changes take affect after logout/login; not ideal but we're limited by
> the Qt QPA for now. Will try and fix that after.
>
> edit: having uploaded this I can see I have some whitespace left, please don't feel \
> the need to tell me.
>
> Diffs
> -----
>
> CMakeLists.txt e157a5e28e441a2e6dacb2d639cf6d120fb18c26
> kcm/src/CMakeLists.txt 50bfdf037c331fe7c6763fb85c3b43857cbea5d5
> kcm/src/previewwidget.h PRE-CREATION
> kcm/src/previewwidget.cpp PRE-CREATION
> kcm/src/scaling.ui PRE-CREATION
> kcm/src/scalingconfig.h PRE-CREATION
> kcm/src/scalingconfig.cpp PRE-CREATION
> kcm/src/stylepreview.ui PRE-CREATION
> kcm/src/widget.cpp 7fe96c1c8b21b19424ef4993dff9eb3985bcefdb
>
> Diff: https://git.reviewboard.kde.org/r/123468/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> the dialog
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/a8cab37c-24bf-4fb9-b50b-39bc34596938__snapshot1.png
>
>
> Thanks,
>
> David Edmundson
>
>
--===============5924823514760064274==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123468/">https://git.reviewboard.kde.org/r/123468/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juli 27th, 2015, 10:36 vorm. UTC, <b>Daniel \
Vrátil</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Another idea: should we somehow somewhere show a \
message that this only applies after logout/login? Otherwise we get bugreports that \
it does not work :)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah \
perhaps place a KMessageWidget at the top that says that (or the ugly dialog we \
usually use in fonts)</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Juli 26th, 2015, 2:35 nachm. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Juli 26, 2015, 2:35 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Single dialog alters both QT_DEVICE_PIXEL_RAITO and \
XRDB.DPI text scaling factor that used to reside in fonts KCM.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A preview widget shows how this will look on the that \
monitor.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Changes take affect after logout/login; not ideal but \
we're limited by the Qt QPA for now. Will try and fix that after.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">edit: having uploaded this I can see I have some \
whitespace left, please don't feel the need to tell me.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(e157a5e28e441a2e6dacb2d639cf6d120fb18c26)</span></li>
<li>kcm/src/CMakeLists.txt <span style="color: \
grey">(50bfdf037c331fe7c6763fb85c3b43857cbea5d5)</span></li>
<li>kcm/src/previewwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcm/src/previewwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcm/src/scaling.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcm/src/scalingconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcm/src/scalingconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcm/src/stylepreview.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kcm/src/widget.cpp <span style="color: \
grey">(7fe96c1c8b21b19424ef4993dff9eb3985bcefdb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123468/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/22/a8cab37c-24bf-4fb9-b50b-39bc34596938__snapshot1.png">the \
dialog</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5924823514760064274==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic