'Re: Review Request 123557: FindQalculate: Use FindPkgConfig instead of UsePkgConfig'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123557: FindQalculate: Use FindPkgConfig instead of UsePkgConfig
From:       "Heiko Becker" <heirecka () exherbo ! org>
Date:       2015-07-16 21:08:24
Message-ID: 20150716210824.27368.26932 () mimi ! kde ! org
[Download RAW message or body]

--===============5113797229642569977==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123557/#review82588
-----------------------------------------------------------

Ping?

- Heiko Becker

On April 29, 2015, Mittag, Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123557/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, Mittag)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The latter is deprecated and doesn't respect the PKG_CONFIG
> environment variable which makes it easy to deal with differently
> named pkg-config executables, e.g. arch-prefixed ones.
> 
> 
> Diffs
> -----
> 
> cmake/FindQalculate.cmake 707a9f7c96b16daf18c1b75400eb8ac4dd30da2c 
> 
> Diff: https://git.reviewboard.kde.org/r/123557/diff/
> 
> 
> Testing
> -------
> 
> Configured, built and checked that plasma-workspace links to qualculate and cln.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
> 

--===============5113797229642569977==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123557/">https://git.reviewboard.kde.org/r/123557/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping?</pre>  <br />

<p>- Heiko Becker</p>

<br />
<p>On April 29th, 2015, Mittag UTC, Heiko Becker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Heiko Becker.</div>

<p style="color: grey;"><i>Updated April 29, 2015, Mittag</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The latter is deprecated and doesn&#39;t respect the PKG_CONFIG \
environment variable which makes it easy to deal with differently named pkg-config \
executables, e.g. arch-prefixed ones.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Configured, built and checked that plasma-workspace links to qualculate \
and cln.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/FindQalculate.cmake <span style="color: \
grey">(707a9f7c96b16daf18c1b75400eb8ac4dd30da2c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123557/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5113797229642569977==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 