[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124270: [kcms/input] Ensure X11 specific code doesn't crash on other platforms
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-07-07 11:42:56
Message-ID: 20150707114256.16549.28332 () mimi ! kde ! org
[Download RAW message or body]
--===============6909397170913090031==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124270/
-----------------------------------------------------------
(Updated July 7, 2015, 11:42 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 889f640dc6ceaf5e6bf00d116da5a6101cd74043 by Martin Gräßlin to \
branch master.
Repository: plasma-desktop
Description
-------
For the kcminit_mouse it's important to also function on Xwayland in
order to set correct cursor information for X clients. Thus if it's
not on platform xcb it tries to open an X connection the old way.
Diffs
-----
kcms/input/main.cpp 9703e793665ca78c2d05f4395199faa6cdf78ff4
kcms/input/mouse.h 8ec0a95f5dcb929dff87ace152357e022a5979f6
kcms/input/mouse.cpp a190effaad68390b3e3e36405b689a53895c9a98
Diff: https://git.reviewboard.kde.org/r/124270/diff/
Testing
-------
No longer crashes on Wayland
Thanks,
Martin Gräßlin
--===============6909397170913090031==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124270/">https://git.reviewboard.kde.org/r/124270/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated July 7, 2015, 11:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 889f640dc6ceaf5e6bf00d116da5a6101cd74043 by Martin \
Gräßlin to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For the kcminit_mouse it's important to also function on Xwayland in \
order to set correct cursor information for X clients. Thus if it's not on \
platform xcb it tries to open an X connection the old way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">No longer crashes on Wayland</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/input/main.cpp <span style="color: \
grey">(9703e793665ca78c2d05f4395199faa6cdf78ff4)</span></li>
<li>kcms/input/mouse.h <span style="color: \
grey">(8ec0a95f5dcb929dff87ace152357e022a5979f6)</span></li>
<li>kcms/input/mouse.cpp <span style="color: \
grey">(a190effaad68390b3e3e36405b689a53895c9a98)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124270/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6909397170913090031==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic