[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124267: Use KWin to lower/raiser panel in windows can cover mode with edge activa
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-07-06 13:27:54
Message-ID: 20150706132754.29751.71455 () mimi ! kde ! org
[Download RAW message or body]
--===============8799434044629704528==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 6, 2015, 12:51 p.m., Kai Uwe Broulik wrote:
> > shell/panelview.cpp, line 348
> > <https://git.reviewboard.kde.org/r/124267/diff/1/?file=383465#file383465line348>
> >
> > if (!(foo || bar)) makes my head explode
yeah, seems not just overly complicated but also completely wrong.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124267/#review82123
-----------------------------------------------------------
On July 6, 2015, 12:36 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124267/
> -----------------------------------------------------------
>
> (Updated July 6, 2015, 12:36 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Use KWin to lower/raiser panel in windows can cover mode with edge activation like \
> autohide does.
> This means if you have a maxmised menu you can still open the panel by moving the \
> mouse to the bottom of the screen
> --
> Requires new incoming kwin patch.
>
>
> Diffs
> -----
>
> shell/panelview.h a41f9883da90bf661f4963e3b2e60a1dc49ab08c
> shell/panelview.cpp b94673d72fa4b226613338c31eb2300f4372b5d2
>
> Diff: https://git.reviewboard.kde.org/r/124267/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
--===============8799434044629704528==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124267/">https://git.reviewboard.kde.org/r/124267/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 6th, 2015, 12:51 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124267/diff/1/?file=383465#file383465line348" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/panelview.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
PanelView::setVisibilityMode(PanelView::VisibilityMode mode)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">348</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="o">!</span><span class="p">(</span><span \
class="n">mode</span> <span class="o">==</span> <span class="n">NormalPanel</span> \
<span class="o">||</span> <span class="n"><span class="hl">mode</span></span><span \
class="hl"> </span><span class="o"><span class="hl">==</span></span><span class="hl"> \
</span><span class="n"><span class="hl">WindowsGoBelow</span></span><span class="hl"> \
</span><span class="o"><span class="hl">||</span></span><span class="hl"> \
</span><span class="n"><span class="hl">mode</span></span><span class="hl"> \
</span><span class="o"><span class="hl">==</span></span><span class="hl"> \
</span><span class="n"><span class="hl">AutoHide</span></span><span \
class="p">))</span> <span class="p">{</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">342</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> \
<span class="p">(</span><span class="o">!</span><span class="p">(</span><span \
class="n">mode</span> <span class="o">==</span> <span class="n">NormalPanel</span> \
<span class="o">||</span> <span class="n"><span \
class="hl">edgeActivated</span></span><span class="p"><span \
class="hl">()</span>))</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if \
(!(foo || bar)) makes my head explode</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">yeah, seems not just overly complicated but also completely \
wrong.</p></pre> <br />
<p>- David</p>
<br />
<p>On July 6th, 2015, 12:36 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated July 6, 2015, 12:36 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use KWin to lower/raiser panel in windows can cover \
mode with edge activation like autohide does.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
means if you have a maxmised menu you can still open the panel by moving the mouse to \
the bottom of the screen</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">-- Requires new incoming kwin \
patch.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/panelview.h <span style="color: \
grey">(a41f9883da90bf661f4963e3b2e60a1dc49ab08c)</span></li>
<li>shell/panelview.cpp <span style="color: \
grey">(b94673d72fa4b226613338c31eb2300f4372b5d2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124267/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8799434044629704528==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic