[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124234: Add option to always show all system tray icons
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2015-07-02 19:58:27
Message-ID: 20150702195827.1689.74090 () mimi ! kde ! org
[Download RAW message or body]
--===============8306389996579271699==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124234/#review82012
-----------------------------------------------------------
Requested a long time ago (for KDE 4) as https://git.reviewboard.kde.org/r/100743/
Good luck...
- Jonathan Marten
On July 2, 2015, 7:47 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124234/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 7:47 p.m.)
>
>
> Review request for Plasma and KDE Usability.
>
>
> Bugs: 349812
> https://bugs.kde.org/show_bug.cgi?id=349812
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This adds an option to always show all system tray icons and never collapse them \
> into the popup. I've seen a couple of people already requesting this.
>
> Diffs
> -----
>
> applets/systemtray/package/contents/config/main.xml 8e8996c
> applets/systemtray/package/contents/ui/ConfigEntries.qml 8b6ec28
> applets/systemtray/package/contents/ui/main.qml e794d1c
> applets/systemtray/plugin/host.h bd9728b
> applets/systemtray/plugin/host.cpp 5c897fa
>
> Diff: https://git.reviewboard.kde.org/r/124234/diff/
>
>
> Testing
> -------
>
> Enabled and disabled the option and tray icons along with the arrow came and went, \
> started music player and media controller properly appeared and disappeared, \
> started and quit KMail and its icon properla appeared and disappeared with both \
> options.
>
> File Attachments
> ----------------
>
> Settings dialog (disabled)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png
> Settings dialog (enabled)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png
> System Tray (disabled)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png
> System Tray (enabled)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============8306389996579271699==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124234/">https://git.reviewboard.kde.org/r/124234/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Requested a long time ago (for KDE 4) as \
https://git.reviewboard.kde.org/r/100743/ Good luck...</p></pre>
<br />
<p>- Jonathan Marten</p>
<br />
<p>On July 2nd, 2015, 7:47 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated July 2, 2015, 7:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=349812">349812</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds an option to always show all system tray \
icons and never collapse them into the popup. I've seen a couple of people already \
requesting this.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Enabled and disabled the option and tray icons along \
with the arrow came and went, started music player and media controller properly \
appeared and disappeared, started and quit KMail and its icon properla appeared and \
disappeared with both options.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/config/main.xml <span style="color: \
grey">(8e8996c)</span></li>
<li>applets/systemtray/package/contents/ui/ConfigEntries.qml <span style="color: \
grey">(8b6ec28)</span></li>
<li>applets/systemtray/package/contents/ui/main.qml <span style="color: \
grey">(e794d1c)</span></li>
<li>applets/systemtray/plugin/host.h <span style="color: grey">(bd9728b)</span></li>
<li>applets/systemtray/plugin/host.cpp <span style="color: \
grey">(5c897fa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124234/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/50ae2a2e-8052-4d87-85c3-5ad8aa1da1f4__trayalways_dialog.png">Settings \
dialog (disabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/d79b67e9-9950-4fb7-97a9-b89b93caeeb7__trayalways_dialogenabled.png">Settings \
dialog (enabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/1b122131-88b0-410c-8532-8dbb74cad5db__trayalways_disabled.png">System \
Tray (disabled)</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/02/3668a352-65c1-4d34-94d8-bc7141ce784e__trayalways_enabled.png">System \
Tray (enabled)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8306389996579271699==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic