'Re: Review Request 124206: Use proper relative paths to import js code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124206: Use proper relative paths to import js code
From:       Sebastian_Kügler <sebas () kde ! org>
Date:       2015-06-29 12:05:38
Message-ID: 20150629120538.7067.7108 () mimi ! kde ! org
[Download RAW message or body]

--===============5203106246322652555==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124206/#review81857
-----------------------------------------------------------

Ship it!

Ship It!

- Sebastian Kügler

On June 29, 2015, 7:17 a.m., Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124206/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 7:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Use proper relative paths to import js code
> 
> 
> Diffs
> -----
> 
> applets/pager/package/contents/ui/main.qml a5d99c9951ecc104a0ad36246df60ebf11a78197 \
>  containments/desktop/package/contents/ui/AppletAppearance.qml \
> 9f71c8c706b610dfada422143bd3903cf6aa3f73  \
> containments/desktop/package/contents/ui/AppletHandle.qml \
> a777eafc87e82cf3fa97b43fd1b22b50276faac8  \
> containments/desktop/package/contents/ui/FolderView.qml \
> 8cc159e83b9ac139482d7c65aa25bb4f0f87bd3d  \
> containments/desktop/package/contents/ui/main.qml \
> 2ec1f0c83bb4dc1b864d13b76004436afdc10ecb  \
> containments/panel/contents/ui/ConfigOverlay.qml \
> a89a5feafd04766a295932a595e788516870c2ff  containments/panel/contents/ui/main.qml \
> 1ed0dc2a79476895ebfa38eb1f52c3bcb98fa780  
> Diff: https://git.reviewboard.kde.org/r/124206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Ottens
> 
> 

--===============5203106246322652555==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124206/">https://git.reviewboard.kde.org/r/124206/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Sebastian Kügler</p>

<br />
<p>On June 29th, 2015, 7:17 a.m. UTC, Kevin Ottens wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kevin Ottens.</div>

<p style="color: grey;"><i>Updated June 29, 2015, 7:17 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use proper relative paths to import js code</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/pager/package/contents/ui/main.qml <span style="color: \
grey">(a5d99c9951ecc104a0ad36246df60ebf11a78197)</span></li>

 <li>containments/desktop/package/contents/ui/AppletAppearance.qml <span \
style="color: grey">(9f71c8c706b610dfada422143bd3903cf6aa3f73)</span></li>

 <li>containments/desktop/package/contents/ui/AppletHandle.qml <span style="color: \
grey">(a777eafc87e82cf3fa97b43fd1b22b50276faac8)</span></li>

 <li>containments/desktop/package/contents/ui/FolderView.qml <span style="color: \
grey">(8cc159e83b9ac139482d7c65aa25bb4f0f87bd3d)</span></li>

 <li>containments/desktop/package/contents/ui/main.qml <span style="color: \
grey">(2ec1f0c83bb4dc1b864d13b76004436afdc10ecb)</span></li>

 <li>containments/panel/contents/ui/ConfigOverlay.qml <span style="color: \
grey">(a89a5feafd04766a295932a595e788516870c2ff)</span></li>

 <li>containments/panel/contents/ui/main.qml <span style="color: \
grey">(1ed0dc2a79476895ebfa38eb1f52c3bcb98fa780)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124206/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5203106246322652555==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 