From kde-panel-devel Fri Jun 26 11:48:04 2015 From: "Alexander Potashev" Date: Fri, 26 Jun 2015 11:48:04 +0000 To: kde-panel-devel Subject: Re: Review Request 124149: Rework the notifications sizing code Message-Id: <20150626114804.20764.940 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143531929821363 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1977294049290170825==" --===============1977294049290170825== Content-Type: multipart/alternative; boundary="===============7670736083615747779==" --===============7670736083615747779== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On June 24, 2015, 12:32 p.m., Alexander Potashev wrote: > > Sorry for off-topic, is it possible to see the full text that was elided? If not, I'm going to file a feature request on bko. > > Martin Klapetek wrote: > No; notifications should really be short and meaningfull, placing 10 lines text inside a notification kinda defeats the purpose of the notifications and such notifications should be fixed at the source. I'm not asking to make the whole notification text visible right away. We can add a button that would expand the notification or open its full version in a dialog. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124149/#review81722 ----------------------------------------------------------- On June 22, 2015, 4:53 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124149/ > ----------------------------------------------------------- > > (Updated June 22, 2015, 4:53 p.m.) > > > Review request for Plasma and Kai Uwe Broulik. > > > Bugs: 339588 and 349142 > https://bugs.kde.org/show_bug.cgi?id=339588 > https://bugs.kde.org/show_bug.cgi?id=349142 > > > Repository: plasma-workspace > > > Description > ------- > > This reworks the notification sizing computation to use Layouts. This should fix all the popup sizing issues there are (including a binding loop error). > > Now it also properly elides after max 4 lines of text. > > > Diffs > ----- > > applets/notifications/package/contents/ui/NotificationItem.qml 176ae91 > applets/notifications/package/contents/ui/NotificationPopup.qml e4e5fad > > Diff: https://git.reviewboard.kde.org/r/124149/diff/ > > > Testing > ------- > > I've been running it for couple hours, all notifications have correct sizes, see screenshot > > > File Attachments > ---------------- > > Screenshot > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/f4f7689c-2a95-46aa-8e51-e90d25d99bb2__notifications-layout.png > > > Thanks, > > Martin Klapetek > > --===============7670736083615747779== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124149/

On June 24th, 2015, 12:32 p.m. UTC, Alexander Potashev wrote:

Sorry for off-topic, is it possible to see the full text that was elided? If not, I'm going to file a feature request on bko.

On June 24th, 2015, 12:42 p.m. UTC, Martin Klapetek wrote:

No; notifications should really be short and meaningfull, placing 10 lines text inside a notification kinda defeats the purpose of the notifications and such notifications should be fixed at the source.

I'm not asking to make the whole notification text visible right away. We can add a button that would expand the notification or open its full version in a dialog.

- Alexander

On June 22nd, 2015, 4:53 p.m. UTC, Martin Klapetek wrote:

Review request for Plasma and Kai Uwe Broulik.

By Martin Klapetek.

Updated June 22, 2015, 4:53 p.m.

Bugs: 339588, 349142

Repository: plasma-workspace

Description

This reworks the notification sizing computation to use Layouts. This should fix all the popup sizing issues there are (including a binding loop error).

Now it also properly elides after max 4 lines of text.

Testing

I've been running it for couple hours, all notifications have correct sizes, see screenshot

Diffs

applets/notifications/package/contents/ui/NotificationItem.qml (176ae91)
applets/notifications/package/contents/ui/NotificationPopup.qml (e4e5fad)

File Attachments

--===============7670736083615747779==-- --===============1977294049290170825== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1977294049290170825==--