From kde-panel-devel Thu Jun 25 09:39:16 2015 From: "Martin Klapetek" Date: Thu, 25 Jun 2015 09:39:16 +0000 To: kde-panel-devel Subject: Re: Review Request 124151: Add a default icon to notifications popup Message-Id: <20150625093916.20764.93913 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143522518326690 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6603455143361477852==" --===============6603455143361477852== Content-Type: multipart/alternative; boundary="===============5919959687429805311==" --===============5919959687429805311== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/ ----------------------------------------------------------- (Updated June 25, 2015, 9:39 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit eb5693810e6d0e907071e15dc1acf8b32dac534a by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description ------- Currently there's none and if there's just a summary text ($ notify-send text), the notification popup looks strange. Adding the default icon makes it look more consistent and not totally-out-of-place-command-line-notification. Diffs ----- applets/notifications/package/contents/ui/NotificationItem.qml 9e413f9 Diff: https://git.reviewboard.kde.org/r/124151/diff/ Testing ------- See screenshot File Attachments ---------------- Screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png No icon notification https://git.reviewboard.kde.org/media/uploaded/files/2015/06/23/06c769be-b5fc-4360-9aac-6f3179601d92__notifications-layout1.png Thanks, Martin Klapetek --===============5919959687429805311== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124151/

This change has been marked as submitted.

Review request for Plasma.
By Martin Klapetek.

Updated June 25, 2015, 9:39 a.m.

Changes

Submitted with commit eb5693810e6d0e907071e15dc1acf8b32dac534a by Martin Klapetek to branch Plasma/5.3.
Repository: plasma-workspace

Description 

Currently there's none and if there's just a summary text ($ notify-send text), the notification popup looks strange. Adding the default icon makes it look more consistent and not totally-out-of-place-command-line-notification.

Testing 

See screenshot

Diffs

  • applets/notifications/package/contents/ui/NotificationItem.qml (9e413f9)

View Diff

File Attachments

  • Screenshot
  • No icon notification
    		•
    --===============5919959687429805311==-- --===============6603455143361477852== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============6603455143361477852==--