[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124151: Add a default icon to notifications popup
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2015-06-22 20:38:19
Message-ID: 20150622203819.26033.53831 () mimi ! kde ! org
[Download RAW message or body]
--===============2968323235155122795==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 22, 2015, 5:54 p.m., Kai Uwe Broulik wrote:
> > what about just freeing the space instead? i'm find with this solution though
>
> Martin Klapetek wrote:
> I didn't do that for two reasons - apps/commands setting no icon would just look \
> out of place with their notification. Second is that the icon plays an important \
> part in the layout - it sets min height as well as having anchors attached to it. \
> It could be changed but would make the layouting more complex imo, which is not \
> worth it for the reason #1.
I'm on the fence here as well. If we can remove an icon that doesn't bear any \
semantic meaning (the notification popups share, location and appearance already \
conveys "this is a notification". If we can avoid clutter, that's always a good \
thing.
I think the reasons Martin gives are invalid from a user point of view (adding an \
icon to fix layout sizing seems wrong).
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124151/#review81666
-----------------------------------------------------------
On June 22, 2015, 5:51 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124151/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 5:51 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Currently there's none and if there's just a summary text ($ notify-send text), the \
> notification popup looks strange. Adding the default icon makes it look more \
> consistent and not totally-out-of-place-command-line-notification.
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/Notifications.qml 13be7d4
>
> Diff: https://git.reviewboard.kde.org/r/124151/diff/
>
>
> Testing
> -------
>
> See screenshot
>
>
> File Attachments
> ----------------
>
> Screenshot
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============2968323235155122795==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124151/">https://git.reviewboard.kde.org/r/124151/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 22nd, 2015, 5:54 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">what about just freeing the space instead? i'm find \
with this solution though</p></pre> </blockquote>
<p>On June 22nd, 2015, 6:02 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
didn't do that for two reasons - apps/commands setting no icon would just look out of \
place with their notification. Second is that the icon plays an important part in the \
layout - it sets min height as well as having anchors attached to it. It could be \
changed but would make the layouting more complex imo, which is not worth it for the \
reason #1.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
on the fence here as well. If we can remove an icon that doesn't bear any semantic \
meaning (the notification popups share, location and appearance already conveys "this \
is a notification". If we can avoid clutter, that's always a good thing.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I think the reasons Martin gives are invalid from a user point of view \
(adding an icon to fix layout sizing seems wrong).</p></pre> <br />
<p>- Sebastian</p>
<br />
<p>On June 22nd, 2015, 5:51 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 22, 2015, 5:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently there's none and if there's just a summary \
text ($ notify-send text), the notification popup looks strange. Adding the default \
icon makes it look more consistent and not \
totally-out-of-place-command-line-notification.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See screenshot</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: \
grey">(13be7d4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124151/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/22/0d8a0ee1-af00-410c-80f1-79190f51daf5__notification-default-icon.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2968323235155122795==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic