From kde-panel-devel Mon Jun 22 08:54:47 2015 From: "Martin Klapetek" Date: Mon, 22 Jun 2015 08:54:47 +0000 To: kde-panel-devel Subject: Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enab Message-Id: <20150622085447.26033.13752 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143496331514599 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7109201335711575853==" --===============7109201335711575853== Content-Type: multipart/alternative; boundary="===============7571437820823481783==" --===============7571437820823481783== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/ ----------------------------------------------------------- (Updated June 22, 2015, 8:54 a.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit b533e7d13f7daac129d4f91b4cdd12d9362ff15b by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description ------- We're getting lots of reports about notifications not being "closeable on click" or "not having any actions" or "not having Plasma theme". These all mostly come from users which have notify-osd package from Unity (ie. Ubuntu users installing plasma-desktop), but not only. So this patch makes Plasma always be the Notification service provider if that option is enabled in the applet settings and/or if the applet is present somewhere (otherwise the dataengine is not loaded). On startup, it will get the PID of the current Notifications service, send SIGTERM to it and register its own service. Diffs ----- dataengines/notifications/notificationsengine.h 7810787 dataengines/notifications/notificationsengine.cpp c3bf373 Diff: https://git.reviewboard.kde.org/r/124102/diff/ Testing ------- Having notify-osd running, plasmashell starts up, notify-osd is terminated, Plasma notifications appear. Thanks, Martin Klapetek --===============7571437820823481783== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/

This change has been marked as submitted.

Review request for Plasma.
By Martin Klapetek.

Updated June 22, 2015, 8:54 a.m.

Changes

Submitted with commit b533e7d13f7daac129d4f91b4cdd12d9362ff15b by Martin Klapetek to branch Plasma/5.3.
Repository: plasma-workspace

Description 

We're getting lots of reports about notifications not being "closeable on click" or "not having any actions" or "not having Plasma theme". These all mostly come from users which have notify-osd package from Unity (ie. Ubuntu users installing plasma-desktop), but not only.


So this patch makes Plasma always be the Notification service provider if that option is enabled in the applet settings and/or if the applet is present somewhere (otherwise the dataengine is not loaded). On startup, it will get the PID of the current Notifications service, send SIGTERM to it and register its own service.

Testing 

Having notify-osd running, plasmashell starts up, notify-osd is terminated, Plasma notifications appear.

Diffs

  • dataengines/notifications/notificationsengine.h (7810787)
  • dataengines/notifications/notificationsengine.cpp (c3bf373)

View Diff
--===============7571437820823481783==-- --===============7109201335711575853== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7109201335711575853==--