--===============6440858516835324848== Content-Type: multipart/alternative; boundary="===============2435005290299203272==" --===============2435005290299203272== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/ ----------------------------------------------------------- (Updated June 19, 2015, 9:34 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit dd3a50102e985fe6414953c258ca6e2659ed1de6 by Kai Uwe Broulik to branch master. Bugs: 348378 https://bugs.kde.org/show_bug.cgi?id=348378 Repository: plasma-desktop Description ------- This allows to drag files onto the trash applet to trash them. Also, the code is cleaned up a bit and it is given a sensible minimum size (so the label always fits) as well as the query dialog has been replaced by the standard KIO dialog. Diffs ----- applets/trash/package/contents/ui/main.qml 7715439 applets/trash/plugin/CMakeLists.txt 9012e66 applets/trash/plugin/trash.h PRE-CREATION applets/trash/plugin/trash.cpp PRE-CREATION applets/trash/plugin/trashplugin.cpp 7e866a9 Diff: https://git.reviewboard.kde.org/r/124112/diff/ Testing ------- Trashed one or multiple files on both desktop and panel. When I dismiss the message box, however, Plasma will create an applet for the file dragged. How can I tell it I accepted the drop? Also, it crashes in Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times after dismissing the dialog. Thanks, Kai Uwe Broulik --===============2435005290299203272== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124112/

This change has been marked as submitted.

Review request for Plasma.
By Kai Uwe Broulik.

Updated June 19, 2015, 9:34 p.m.

Changes

Submitted with commit dd3a50102e985fe6414953c258ca6e2659ed1de6 by Kai Uwe Broulik to branch master.
Bugs: 348378
Repository: plasma-desktop

Description 

This allows to drag files onto the trash applet to trash them.
Also, the code is cleaned up a bit and it is given a sensible minimum size (so the label always fits) as well as the query dialog has been replaced by the standard KIO dialog.

Testing 

Trashed one or multiple files on both desktop and panel.
When I dismiss the message box, however, Plasma will create an applet for the file dragged. How can I tell it I accepted the drop? Also, it crashes in Client::~Client() () from /usr/lib/x86_64-linux-gnu/libQPulseAudioPrivate.so at times after dismissing the dialog.

Diffs

  • applets/trash/package/contents/ui/main.qml (7715439)
  • applets/trash/plugin/CMakeLists.txt (9012e66)
  • applets/trash/plugin/trash.h (PRE-CREATION)
  • applets/trash/plugin/trash.cpp (PRE-CREATION)
  • applets/trash/plugin/trashplugin.cpp (7e866a9)

View Diff
--===============2435005290299203272==-- --===============6440858516835324848== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============6440858516835324848==--