'Re: Review Request 124108: [kcms/phonon] Don't overwrite audio profile entries with same priority'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124108: [kcms/phonon] Don't overwrite audio profile entries with same priority
From:       "Bernie Innocenti" <bernie () codewiz ! org>
Date:       2015-06-17 17:30:18
Message-ID: 20150617173018.14517.34841 () mimi ! kde ! org
[Download RAW message or body]

--===============2397366999257689968==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124108/
-----------------------------------------------------------

(Updated June 17, 2015, 5:30 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Harald Sitter.

Changes
-------

Submitted with commit 4b576cd02867672069c8077a43bb7caf442de8cc by Harald Sitter on \
behalf of Bernie Innocenti to branch Plasma/5.3.

Repository: plasma-desktop

Description
-------

My system has 3 HDMI ports, and HDMI2 is listed in pavucontrol,
but not in kcm_phonon. The reason was that HDMI2 and HDMI3 had the
same priority, and were overwriting each other in the cardInfo profiles
map. The fix consists in switching to a multimap.

Diffs
-----

  kcms/phonon/audiosetup.h dfb25bf8c111d72065a27bb91583026093f0598d 

Diff: https://git.reviewboard.kde.org/r/124108/diff/

Testing
-------

Manually tested with:
  QT_PLUGIN_PATH="$PWD:$QT_PLUGIN_PATH" kcmshell5 kcm_phonon

Thanks,

Bernie Innocenti

--===============2397366999257689968==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124108/">https://git.reviewboard.kde.org/r/124108/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Harald Sitter.</div>
<div>By Bernie Innocenti.</div>

<p style="color: grey;"><i>Updated June 17, 2015, 5:30 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 4b576cd02867672069c8077a43bb7caf442de8cc by Harald \
Sitter on behalf of Bernie Innocenti to branch Plasma/5.3.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">My system has 3 HDMI ports, and HDMI2 is listed in pavucontrol, but not \
in kcm_phonon. The reason was that HDMI2 and HDMI3 had the same priority, and were \
overwriting each other in the cardInfo profiles map. The fix consists in switching to \
a multimap.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Manually tested with:  \
QT_PLUGIN_PATH="$PWD:$QT_PLUGIN_PATH" kcmshell5 kcm_phonon</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcms/phonon/audiosetup.h <span style="color: \
grey">(dfb25bf8c111d72065a27bb91583026093f0598d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124108/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2397366999257689968==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 