[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124110: SystemLoadViewer opens KSysGuard on click
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2015-06-16 13:26:08
Message-ID: 20150616132608.14517.7753 () mimi ! kde ! org
[Download RAW message or body]
--===============3310092918082434994==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On June 16, 2015, 4:40 p.m., Bhushan Shah wrote:
> > Thanks for patch, do you have commit access or I can commit that for you.
>
> Joshua Worth wrote:
> I don't think I do, so that would be great thanks. This is the first patch I \
> submitted by myself.
Done, submitted with \
http://commits.kde.org/kdeplasma-addons/6ecc5fc44e9ffc1535bfff1157be1b3efef875e2
- Bhushan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124110/#review81510
-----------------------------------------------------------
On June 16, 2015, 6:54 p.m., Joshua Worth wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124110/
> -----------------------------------------------------------
>
> (Updated June 16, 2015, 6:54 p.m.)
>
>
> Review request for Plasma, David Edmundson and Martin Yrjölä.
>
>
> Repository: kdeplasma-addons
>
>
> Description
> -------
>
> The SystemLoadViewer widget should open KSysGuard when clicked, but the DataSource \
> was set to the wrong source
>
> Diffs
> -----
>
> applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 43acab4
>
> Diff: https://git.reviewboard.kde.org/r/124110/diff/
>
>
> Testing
> -------
>
> Tested in panel and on desktop
>
>
> Thanks,
>
> Joshua Worth
>
>
--===============3310092918082434994==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124110/">https://git.reviewboard.kde.org/r/124110/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 16th, 2015, 4:40 p.m. IST, <b>Bhushan \
Shah</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks for patch, do you have commit access or I can \
commit that for you.</p></pre> </blockquote>
<p>On June 16th, 2015, 6:47 p.m. IST, <b>Joshua Worth</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
don't think I do, so that would be great thanks. This is the first patch I submitted \
by myself.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Done, \
submitted with http://commits.kde.org/kdeplasma-addons/6ecc5fc44e9ffc1535bfff1157be1b3efef875e2</p></pre>
<br />
<p>- Bhushan</p>
<br />
<p>On June 16th, 2015, 6:54 p.m. IST, Joshua Worth wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, David Edmundson and Martin Yrjölä.</div>
<div>By Joshua Worth.</div>
<p style="color: grey;"><i>Updated June 16, 2015, 6:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The SystemLoadViewer widget should open KSysGuard when \
clicked, but the DataSource was set to the wrong source</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested in panel and on desktop</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml <span \
style="color: grey">(43acab4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124110/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3310092918082434994==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic