[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enab
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-06-15 19:32:49
Message-ID: 20150615193249.15191.24291 () mimi ! kde ! org
[Download RAW message or body]
--===============4668835825880540864==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On June 15, 2015, 9:29 p.m., Lukáš Tinkl wrote:
> > A better option would be to call registerService() with \
> > QDBusConnectionInterface::ReplaceExistingService and \
> > DBusConnectionInterface::AllowReplacement
It's the "attempt to replace it." part of it that I'm not entirely happy with. Plus \
we don't actually get to control all the servers and set "AllowReplacement" on them, \
so this might not be feasible in the end.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124102/#review81489
-----------------------------------------------------------
On June 15, 2015, 4:30 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124102/
> -----------------------------------------------------------
>
> (Updated June 15, 2015, 4:30 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> We're getting lots of reports about notifications not being "closeable on click" or \
> "not having any actions" or "not having Plasma theme". These all mostly come from \
> users which have notify-osd package from Unity (ie. Ubuntu users installing \
> plasma-desktop), but not only.
> So this patch makes Plasma always be the Notification service provider if that \
> option is enabled in the applet settings and/or if the applet is present somewhere \
> (otherwise the dataengine is not loaded). On startup, it will get the PID of the \
> current Notifications service, send SIGTERM to it and register its own service.
>
> Diffs
> -----
>
> dataengines/notifications/notificationsengine.h 7810787
> dataengines/notifications/notificationsengine.cpp c3bf373
>
> Diff: https://git.reviewboard.kde.org/r/124102/diff/
>
>
> Testing
> -------
>
> Having notify-osd running, plasmashell starts up, notify-osd is terminated, Plasma \
> notifications appear.
>
> Thanks,
>
> Martin Klapetek
>
>
--===============4668835825880540864==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124102/">https://git.reviewboard.kde.org/r/124102/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 15th, 2015, 9:29 p.m. CEST, <b>Lukáš \
Tinkl</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A better option would be to call registerService() \
with QDBusConnectionInterface::ReplaceExistingService and \
DBusConnectionInterface::AllowReplacement</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
the "attempt to replace it." part of it that I'm not entirely happy with. Plus we \
don't actually get to control all the servers and set "AllowReplacement" on them, so \
this might not be feasible in the end.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On June 15th, 2015, 4:30 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 15, 2015, 4:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We're getting lots of reports about notifications not \
being "closeable on click" or "not having any actions" or "not having Plasma theme". \
These all mostly come from users which have notify-osd package from Unity (ie. Ubuntu \
users installing plasma-desktop), but not only.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So \
this patch makes Plasma always be the Notification service provider if that option is \
enabled in the applet settings and/or if the applet is present somewhere (otherwise \
the dataengine is not loaded). On startup, it will get the PID of the current \
Notifications service, send SIGTERM to it and register its own service.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Having notify-osd running, plasmashell starts up, \
notify-osd is terminated, Plasma notifications appear.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/notifications/notificationsengine.h <span style="color: \
grey">(7810787)</span></li>
<li>dataengines/notifications/notificationsengine.cpp <span style="color: \
grey">(c3bf373)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124102/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4668835825880540864==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic