[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enab
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-06-15 17:50:12
Message-ID: 20150615175012.15191.94226 () mimi ! kde ! org
[Download RAW message or body]
--===============8469746986203255972==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124102/#review81486
-----------------------------------------------------------
+1
*evil laughing up my sleeve*
dataengines/notifications/notificationsengine.cpp (line 63)
<https://git.reviewboard.kde.org/r/124102/#comment55847>
Given we require Qt 5.4, QTimer::singleShot(3000, this, \
&NotificationsEngine::registerDBusService);
- Kai Uwe Broulik
On Juni 15, 2015, 2:30 nachm., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124102/
> -----------------------------------------------------------
>
> (Updated Juni 15, 2015, 2:30 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> We're getting lots of reports about notifications not being "closeable on click" or \
> "not having any actions" or "not having Plasma theme". These all mostly come from \
> users which have notify-osd package from Unity (ie. Ubuntu users installing \
> plasma-desktop), but not only.
> So this patch makes Plasma always be the Notification service provider if that \
> option is enabled in the applet settings and/or if the applet is present somewhere \
> (otherwise the dataengine is not loaded). On startup, it will get the PID of the \
> current Notifications service, send SIGTERM to it and register its own service.
>
> Diffs
> -----
>
> dataengines/notifications/notificationsengine.h 7810787
> dataengines/notifications/notificationsengine.cpp c3bf373
>
> Diff: https://git.reviewboard.kde.org/r/124102/diff/
>
>
> Testing
> -------
>
> Having notify-osd running, plasmashell starts up, notify-osd is terminated, Plasma \
> notifications appear.
>
> Thanks,
>
> Martin Klapetek
>
>
--===============8469746986203255972==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124102/">https://git.reviewboard.kde.org/r/124102/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">evil laughing up my \
sleeve</em></p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/124102/diff/1/?file=379947#file379947line63" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dataengines/notifications/notificationsengine.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">63</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">QTimer</span><span class="o">::</span><span \
class="n">singleShot</span><span class="p">(</span><span class="mi">3000</span><span \
class="p">,</span> <span class="k">this</span><span class="p">,</span> <span \
class="n">SLOT</span><span class="p">(</span><span \
class="n">registerDBusService</span><span class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Given \
we require Qt 5.4, QTimer::singleShot(3000, this, \
&NotificationsEngine::registerDBusService);</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Juni 15th, 2015, 2:30 nachm. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Juni 15, 2015, 2:30 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We're getting lots of reports about notifications not \
being "closeable on click" or "not having any actions" or "not having Plasma theme". \
These all mostly come from users which have notify-osd package from Unity (ie. Ubuntu \
users installing plasma-desktop), but not only.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So \
this patch makes Plasma always be the Notification service provider if that option is \
enabled in the applet settings and/or if the applet is present somewhere (otherwise \
the dataengine is not loaded). On startup, it will get the PID of the current \
Notifications service, send SIGTERM to it and register its own service.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Having notify-osd running, plasmashell starts up, \
notify-osd is terminated, Plasma notifications appear.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/notifications/notificationsengine.h <span style="color: \
grey">(7810787)</span></li>
<li>dataengines/notifications/notificationsengine.cpp <span style="color: \
grey">(c3bf373)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124102/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8469746986203255972==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic