[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124072: Refactor the Calendar grid computation a bit
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-06-15 14:35:38
Message-ID: 20150615143538.15191.96950 () mimi ! kde ! org
[Download RAW message or body]
--===============6246167502216258976==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124072/
-----------------------------------------------------------
(Updated June 15, 2015, 2:35 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit 23add5d6e4c19d353b7d8bdaf9ea2f126e7f30b9 by Martin Klapetek to \
branch master.
Repository: plasma-framework
Description
-------
Makes the code a bit simpler & lighter and fixes the sometimes missing bottom line in \
calendar.
The grid is now equally padded from both sides (including the month name), so \
basically it's now always aligned to the center and this also fixes the cases where \
there was a bigger padding on one side than on the other.
The grid is now also anchored to the bottom so that the bottom margin can stay \
moreless consistent with the side margins in different sizes.
Diffs
-----
src/declarativeimports/calendar/qml/DaysCalendar.qml 5308708
src/declarativeimports/calendar/qml/MonthView.qml 86e37d8
Diff: https://git.reviewboard.kde.org/r/124072/diff/
Testing
-------
Lots of 600x-zoom inspections and pixel counting. Tested both in Calendar applet and \
Digital Clock applet.
Thanks,
Martin Klapetek
--===============6246167502216258976==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124072/">https://git.reviewboard.kde.org/r/124072/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 15, 2015, 2:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 23add5d6e4c19d353b7d8bdaf9ea2f126e7f30b9 by Martin \
Klapetek to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Makes the code a bit simpler & lighter and fixes \
the sometimes missing bottom line in calendar.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
grid is now equally padded from both sides (including the month name), so basically \
it's now always aligned to the center and this also fixes the cases where there was a \
bigger padding on one side than on the other.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The grid is now also anchored to the bottom so that \
the bottom margin can stay moreless consistent with the side margins in different \
sizes.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Lots of 600x-zoom inspections and pixel counting. \
Tested both in Calendar applet and Digital Clock applet.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(5308708)</span></li>
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(86e37d8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124072/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6246167502216258976==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic