[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124047: Improve clock's tooltip layout
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-06-12 5:00:43
Message-ID: 20150612050043.21202.16246 () mimi ! kde ! org
[Download RAW message or body]
--===============6614848683524412709==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124047/#review81403
-----------------------------------------------------------
Ship it!
- Marco Martin
On June 10, 2015, 11:49 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124047/
> -----------------------------------------------------------
>
> (Updated June 10, 2015, 11:49 a.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 348078
> https://bugs.kde.org/show_bug.cgi?id=348078
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> In kde4 times, the layout of clock's tooltip was nicely arranged using a table. Now \
> it's a bit of a mess so this brings back the table.
> Also simplifies the timeForZone function which is used only for the tooltip.
>
>
> Diffs
> -----
>
> applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33
> applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION
> applets/digital-clock/package/contents/ui/main.qml e814056
>
> Diff: https://git.reviewboard.kde.org/r/124047/diff/
>
>
> Testing
> -------
>
> See screenshots.
>
>
> File Attachments
> ----------------
>
> Before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/62594835-6bbb-436d-ba88-f39cb98b3033__clock-tooltip4.png
> After (custom tooltip delegate)
> https://git.reviewboard.kde.org/media/uploaded/files/2015/06/10/70f71cc7-3433-4a9a-bd12-031b82d6ed05__clock-tooltip9.png
>
>
> Thanks,
>
> Martin Klapetek
>
>
--===============6614848683524412709==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124047/">https://git.reviewboard.kde.org/r/124047/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Marco Martin</p>
<br />
<p>On June 10th, 2015, 11:49 a.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated June 10, 2015, 11:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=348078">348078</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">In kde4 times, the layout of clock's tooltip was \
nicely arranged using a table. Now it's a bit of a mess so this brings back the \
table.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also simplifies the timeForZone function which is used \
only for the tooltip.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See screenshots.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/digital-clock/package/contents/ui/DigitalClock.qml <span style="color: \
grey">(a142d33)</span></li>
<li>applets/digital-clock/package/contents/ui/Tooltip.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>applets/digital-clock/package/contents/ui/main.qml <span style="color: \
grey">(e814056)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124047/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/62594835-6bbb-436d-ba88-f39cb98b3033__clock-tooltip4.png">Before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/10/70f71cc7-3433-4a9a-bd12-031b82d6ed05__clock-tooltip9.png">After \
(custom tooltip delegate)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6614848683524412709==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic