'Re: Review Request 124053: [protocols] Reduce plasma-shell to the bare minimum what we need right no'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124053: [protocols] Reduce plasma-shell to the bare minimum what we need right no
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-06-09 19:11:09
Message-ID: 20150609191109.18650.35536 () mimi ! kde ! org
[Download RAW message or body]

--===============0517610326268509537==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124053/
-----------------------------------------------------------

(Updated June 9, 2015, 7:11 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Marco Martin.

Changes
-------

Submitted with commit 7684c4e9d0afd377400b20058e46150b5905e07f by Martin Gräßlin to \
branch master.

Repository: kwayland

Description
-------

We only want to be able to set positions and set window type.

[protocols] Reduce roles in plasma-shell to bare minimum plasma needs

The enum values follow the values uses in NET::WindowType of
KWindowSystem framework.

[client] Add binding for PlasmaShell and PlasmaShellSurface

[server] Add bindings for PlasmaShell interface

[tests] Add a test application for PlasmaShellInterface

Creates a panel.

Diffs
-----

  src/client/CMakeLists.txt ab592b20dde878365df8374ea9a43dbf2f10cb59 
  src/client/plasmashell.h PRE-CREATION 
  src/client/plasmashell.cpp PRE-CREATION 
  src/client/protocols/plasma-shell.xml e555df265acaa24de9261bb5b2fd20a9e5437c64 
  src/client/registry.h 52ef84382fe44951f2e512217c06e7110403e8db 
  src/client/registry.cpp fe2dbed4e594037f65ce5ec629012800e0d5e9eb 
  src/server/CMakeLists.txt 466363466f8dcde490fc7d724d486e68093111d7 
  src/server/display.h 74865992dff816622021e49f1b5a9791c7505163 
  src/server/display.cpp 1796f53f9e70e3fbd6fc8645d8b897c1500544e9 
  src/server/plasmashell_interface.h PRE-CREATION 
  src/server/plasmashell_interface.cpp PRE-CREATION 
  tests/CMakeLists.txt c41b7a3a5a7a078b1fbaa2a3cb0cd90cdd6e7b53 
  tests/paneltest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124053/diff/

Testing
-------

Thanks,

Martin Gräßlin

--===============0517610326268509537==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124053/">https://git.reviewboard.kde.org/r/124053/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated June 9, 2015, 7:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 7684c4e9d0afd377400b20058e46150b5905e07f by Martin \
Gräßlin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We only want to be able to set positions and set window type.

[protocols] Reduce roles in plasma-shell to bare minimum plasma needs

The enum values follow the values uses in NET::WindowType of
KWindowSystem framework.

[client] Add binding for PlasmaShell and PlasmaShellSurface

[server] Add bindings for PlasmaShell interface

[tests] Add a test application for PlasmaShellInterface

Creates a panel.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/client/CMakeLists.txt <span style="color: \
grey">(ab592b20dde878365df8374ea9a43dbf2f10cb59)</span></li>

 <li>src/client/plasmashell.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/client/plasmashell.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/client/protocols/plasma-shell.xml <span style="color: \
grey">(e555df265acaa24de9261bb5b2fd20a9e5437c64)</span></li>

 <li>src/client/registry.h <span style="color: \
grey">(52ef84382fe44951f2e512217c06e7110403e8db)</span></li>

 <li>src/client/registry.cpp <span style="color: \
grey">(fe2dbed4e594037f65ce5ec629012800e0d5e9eb)</span></li>

 <li>src/server/CMakeLists.txt <span style="color: \
grey">(466363466f8dcde490fc7d724d486e68093111d7)</span></li>

 <li>src/server/display.h <span style="color: \
grey">(74865992dff816622021e49f1b5a9791c7505163)</span></li>

 <li>src/server/display.cpp <span style="color: \
grey">(1796f53f9e70e3fbd6fc8645d8b897c1500544e9)</span></li>

 <li>src/server/plasmashell_interface.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/server/plasmashell_interface.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>tests/CMakeLists.txt <span style="color: \
grey">(c41b7a3a5a7a078b1fbaa2a3cb0cd90cdd6e7b53)</span></li>

 <li>tests/paneltest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124053/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0517610326268509537==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 