'Re: Review Request 124004: Add week numbers to calendar - Part 1'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124004: Add week numbers to calendar - Part 1
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-06-05 12:35:12
Message-ID: 20150605123512.8350.86135 () mimi ! kde ! org
[Download RAW message or body]

--===============8733697360005752550==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124004/
-----------------------------------------------------------

(Updated June 5, 2015, 12:35 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 5caba3cfaff270a1a1b376451a56c6506cb4e1ce by Martin Klapetek to \
branch master.

Repository: plasma-framework

Description
-------

One of the most requested features for Plasma5. The backend is all there*, it just \
needs the frontend part. Optional, defaults to off.

*Somehow the Repeater { model: } does not like QList<int>, it just doesn't show \
anything while QStringList works just fine. Any ideas on that?

Diffs
-----

  src/declarativeimports/calendar/calendar.h ea20bf5 
  src/declarativeimports/calendar/calendar.cpp a766acb 
  src/declarativeimports/calendar/qml/DaysCalendar.qml 67b3a2e 
  src/declarativeimports/calendar/qml/MonthView.qml 6eaa8db 

Diff: https://git.reviewboard.kde.org/r/124004/diff/

Testing
-------

File Attachments
----------------

Screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png

Thanks,

Martin Klapetek

--===============8733697360005752550==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124004/">https://git.reviewboard.kde.org/r/124004/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated June 5, 2015, 12:35 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5caba3cfaff270a1a1b376451a56c6506cb4e1ce by Martin \
Klapetek to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One of the most requested features for Plasma5. The backend is all \
there*, it just needs the frontend part. Optional, defaults to off.

*Somehow the Repeater { model: } does not like QList&lt;int&gt;, it just doesn&#39;t \
show anything while QStringList works just fine. Any ideas on that?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/calendar/calendar.h <span style="color: \
grey">(ea20bf5)</span></li>

 <li>src/declarativeimports/calendar/calendar.cpp <span style="color: \
grey">(a766acb)</span></li>

 <li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(67b3a2e)</span></li>

 <li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(6eaa8db)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124004/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/04/2283789a-91e1-4a99-b341-bcaddaaeac85__calendar-weeks6.png">Screenshot</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8733697360005752550==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 