[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123998: [kcms/keybpard] Ensure Keyboard kded doesn't crash on platform wayland
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2015-06-03 23:09:17
Message-ID: 20150603230917.8350.63910 () mimi ! kde ! org
[Download RAW message or body]
--===============2343945791241083527==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123998/
-----------------------------------------------------------
(Updated June 3, 2015, 11:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit ae08e9923d5e03ad1d766d818f3679502d588d20 by Martin Gräßlin to \
branch master.
Repository: plasma-desktop
Description
-------
Required safety checks to make the kded not dead crash kded5 when
running with QT_QPA_PLATFORM=wayland.
Diffs
-----
kcms/keyboard/x11_helper.cpp b85701475f9e29e50235dba0943ac1e95fbd72f5
kcms/keyboard/xkb_rules.cpp 341369da6d44e23e5769ee0fecd2cf08321526cc
Diff: https://git.reviewboard.kde.org/r/123998/diff/
Testing
-------
Thanks,
Martin Gräßlin
--===============2343945791241083527==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123998/">https://git.reviewboard.kde.org/r/123998/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated June 3, 2015, 11:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit ae08e9923d5e03ad1d766d818f3679502d588d20 by Martin \
Gräßlin to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Required safety checks to make the kded not dead crash kded5 when \
running with QT_QPA_PLATFORM=wayland.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/keyboard/x11_helper.cpp <span style="color: \
grey">(b85701475f9e29e50235dba0943ac1e95fbd72f5)</span></li>
<li>kcms/keyboard/xkb_rules.cpp <span style="color: \
grey">(341369da6d44e23e5769ee0fecd2cf08321526cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123998/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2343945791241083527==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic