From kde-panel-devel Sun May 31 12:39:00 2015 From: "Marco Martin" Date: Sun, 31 May 2015 12:39:00 +0000 To: kde-panel-devel Subject: Re: Review Request 123946: Add api to disable plot grid lines Message-Id: <20150531123900.8350.68540 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143307595627831 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2067558605242172755==" --===============2067558605242172755== Content-Type: multipart/alternative; boundary="===============3255395364826757168==" --===============3255395364826757168== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123946/ ----------------------------------------------------------- (Updated May 31, 2015, 12:39 p.m.) Status ------ This change has been discarded. Review request for KDE Frameworks, Plasma and Thomas Pfeiffer. Repository: kdeclarative Description ------- This is from feedback from the VDG: for the system monitor widget would be better to not have the horizontal grid lines for the plots as they don't add much information in this case and clutter the scene a bit. the system monitor applets would make use of this. to maintain compatibility still draw the lines, but add api to disable them (since there already was api for the grid, it shouldn't be broken) Diffs ----- src/qmlcontrols/kquickcontrolsaddons/plotter.h a564761 src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 9a939c3 Diff: https://git.reviewboard.kde.org/r/123946/diff/ Testing ------- Thanks, Marco Martin --===============3255395364826757168== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123946/

This change has been discarded.

Review request for KDE Frameworks, Plasma and Thomas Pfeiffer.

By Marco Martin.

Updated May 31, 2015, 12:39 p.m.

Repository: kdeclarative

Description

This is from feedback from the VDG: for the system monitor widget would be better to not have the horizontal grid lines for the plots as they don't add much information in this case and clutter the scene a bit. the system monitor applets would make use of this.

to maintain compatibility still draw the lines, but add api to disable them (since there already was api for the grid, it shouldn't be broken)

Diffs

src/qmlcontrols/kquickcontrolsaddons/plotter.h (a564761)
src/qmlcontrols/kquickcontrolsaddons/plotter.cpp (9a939c3)

View Diff

--===============3255395364826757168==-- --===============2067558605242172755== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2067558605242172755==--