[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNoti
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-05-28 13:30:59
Message-ID: 20150528133059.31615.1864 () mimi ! kde ! org
[Download RAW message or body]
--===============8434444522919384125==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/#review80924
-----------------------------------------------------------
dataengines/notifications/notificationsengine.cpp
<https://git.reviewboard.kde.org/r/123923/#comment55447>
does this get lost?
- David Edmundson
On May 28, 2015, 1:27 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123923/
> -----------------------------------------------------------
>
> (Updated May 28, 2015, 1:27 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This puts the notifications coming from the Jobs applet through the same routines \
> as normal notifications, including proper parsing and escaping and stuff.
> This also fixes bug 342605
>
>
> Diffs
> -----
>
> applets/notifications/package/contents/ui/Jobs.qml 3307d38
> applets/notifications/package/contents/ui/Notifications.qml 333f5b8
> dataengines/notifications/notificationaction.cpp db27cb3
> dataengines/notifications/notifications.operations 93b7f0c
> dataengines/notifications/notificationsengine.h d8507d0
> dataengines/notifications/notificationsengine.cpp 37a11dd
>
> Diff: https://git.reviewboard.kde.org/r/123923/diff/
>
>
> Testing
> -------
>
> Copy files, notification appears correctly, is closed correctly and everything \
> works as expected.
>
> Thanks,
>
> Martin Klapetek
>
>
--===============8434444522919384125==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123923/">https://git.reviewboard.kde.org/r/123923/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123923/diff/1/?file=378259#file378259line367" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dataengines/notifications/notificationsengine.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QString NotificationsEngine::GetServerInformation(QString& vendor, QString& \
version, QString& specVersion)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">367</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">notificationData</span><span class="p">.</span><span \
class="n">insert</span><span class="p">(</span><span \
class="s">"configurable"</span><span class="p">,</span> <span \
class="n">configurable</span><span class="p">);</span></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">does \
this get lost?</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On May 28th, 2015, 1:27 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 28, 2015, 1:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This puts the notifications coming from the Jobs \
applet through the same routines as normal notifications, including proper parsing \
and escaping and stuff.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This also fixes bug 342605</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Copy files, notification appears correctly, is closed \
correctly and everything works as expected.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/notifications/package/contents/ui/Jobs.qml <span style="color: \
grey">(3307d38)</span></li>
<li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: \
grey">(333f5b8)</span></li>
<li>dataengines/notifications/notificationaction.cpp <span style="color: \
grey">(db27cb3)</span></li>
<li>dataengines/notifications/notifications.operations <span style="color: \
grey">(93b7f0c)</span></li>
<li>dataengines/notifications/notificationsengine.h <span style="color: \
grey">(d8507d0)</span></li>
<li>dataengines/notifications/notificationsengine.cpp <span style="color: \
grey">(37a11dd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123923/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8434444522919384125==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic