[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-05-27 20:41:37
Message-ID: 20150527204137.31615.30233 () mimi ! kde ! org
[Download RAW message or body]
--===============6972044091655055532==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On May 18, 2015, 10:46 a.m., Martin Klapetek wrote:
> > Fwiw, I think it would be much better if the dataengine actually signalled the \
> > disk space change rather than polling, then the applet could just handle the \
> > incoming "changed" signals -> less polling around.
>
> Yoann Laissus wrote:
> What mechanism do you think we can use to monitor disk space changes ? \
> inotify/fanotify ? I'm afraid that the load would be higher with that approach. \
> (with network mounts, for instance)
It's fine if the dataengine polls for the space, but then the applet wouldn't have to \
unless the space actually changed. The dataengine can watch it anyhow and if the free \
space changes, it sends out the signal to which the applet would be connected and \
update its visualization.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123817/#review80566
-----------------------------------------------------------
On May 17, 2015, 1:01 p.m., Yoann Laissus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123817/
> -----------------------------------------------------------
>
> (Updated May 17, 2015, 1:01 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Previously, it was set to 0 so the space indicator was never refreshed.
>
>
> Diffs
> -----
>
> applets/devicenotifier/package/contents/ui/devicenotifier.qml \
> 1fb3d28736fc5effb7e6a6e5940a7bab28c19798
> Diff: https://git.reviewboard.kde.org/r/123817/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yoann Laissus
>
>
--===============6972044091655055532==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123817/">https://git.reviewboard.kde.org/r/123817/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 18th, 2015, 10:46 a.m. CEST, <b>Martin \
Klapetek</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fwiw, I think it would be much better if the \
dataengine actually signalled the disk space change rather than polling, then the \
applet could just handle the incoming "changed" signals -> less polling \
around.</p></pre> </blockquote>
<p>On May 27th, 2015, 10:03 p.m. CEST, <b>Yoann Laissus</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
mechanism do you think we can use to monitor disk space changes ? inotify/fanotify ? \
I'm afraid that the load would be higher with that approach. (with network mounts, \
for instance)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's \
fine if the dataengine polls for the space, but then the applet wouldn't have to \
unless the space actually changed. The dataengine can watch it anyhow and if the free \
space changes, it sends out the signal to which the applet would be connected and \
update its visualization.</p></pre> <br />
<p>- Martin</p>
<br />
<p>On May 17th, 2015, 1:01 p.m. CEST, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated May 17, 2015, 1:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Previously, it was set to 0 so the space indicator was \
never refreshed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/devicenotifier/package/contents/ui/devicenotifier.qml <span \
style="color: grey">(1fb3d28736fc5effb7e6a6e5940a7bab28c19798)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123817/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6972044091655055532==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic