[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123884: Make sure the desktop folderview doesn't overlap with panels.
From: "Yoann Laissus" <yoann.laissus () gmail ! com>
Date: 2015-05-27 19:50:17
Message-ID: 20150527195017.9472.98281 () mimi ! kde ! org
[Download RAW message or body]
--===============7685902804091761185==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On mai 24, 2015, 8:12 après-midi, Eike Hein wrote:
> > Please adapt this to match up with \
> > http://quickgit.kde.org/?p=plasma-desktop.git&a=blob&h=e15933a3d6310cf053d299d32a9 \
> > c0179d1332074&hb=bc4656c9f0405afd1eb0a09ced32d1f2b44f0b52&f=containments%2Ffolder%2Fpackage%2Fcontents%2Fui%2Fmain.qml#l61, \
> > in particular see \
> > http://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=27afc666c7adbc8bf8b0c4ffa7105ecad9ffd27f
> >
>
> Eike Hein wrote:
> ^ That means adding this to the DropArea in main.qml as before btw, the desktop \
> containment used to have it as well (minus the overflow special case).
Updated !
Do you think we need to use the same overflow mechanism for the right margin ?
- Yoann
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123884/#review80784
-----------------------------------------------------------
On mai 27, 2015, 7:47 après-midi, Yoann Laissus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123884/
> -----------------------------------------------------------
>
> (Updated mai 27, 2015, 7:47 après-midi)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Currently, when the desktop is configured with "Folder view" mode, it uses the \
> whole screen, no matter if there are panels in the area. This patch resizes the \
> folder view to the available space to avoid overlaps with panels.
>
> Diffs
> -----
>
> containments/desktop/package/contents/ui/FolderViewLayer.qml \
> 19495b4df4afec18bc90de60ba11eb60b90c52a5 \
> containments/desktop/package/contents/ui/main.qml \
> c546236abf6376963180ffec648d412bcd6e40db
> Diff: https://git.reviewboard.kde.org/r/123884/diff/
>
>
> Testing
> -------
>
> Tested with panels on each screen side
>
>
> File Attachments
> ----------------
>
> Without the patch
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg
> With the patch
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg
>
>
> Thanks,
>
> Yoann Laissus
>
>
--===============7685902804091761185==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123884/">https://git.reviewboard.kde.org/r/123884/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On mai 24th, 2015, 8:12 après-midi UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Please adapt this to match up with \
http://quickgit.kde.org/?p=plasma-desktop.git&a=blob&h=e15933a3d6310cf053d299d \
32a9c0179d1332074&hb=bc4656c9f0405afd1eb0a09ced32d1f2b44f0b52&f=containments%2Ffolder%2Fpackage%2Fcontents%2Fui%2Fmain.qml#l61, \
in particular see http://quickgit.kde.org/?p=plasma-desktop.git&a=commit&h=27afc666c7adbc8bf8b0c4ffa7105ecad9ffd27f</p></pre>
</blockquote>
<p>On mai 24th, 2015, 8:15 après-midi UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">^ \
That means adding this to the DropArea in main.qml as before btw, the desktop \
containment used to have it as well (minus the overflow special case).</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Updated ! Do you think we need to use the same overflow mechanism for the \
right margin ?</p></pre> <br />
<p>- Yoann</p>
<br />
<p>On mai 27th, 2015, 7:47 après-midi UTC, Yoann Laissus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>
<p style="color: grey;"><i>Updated mai 27, 2015, 7:47 après-midi</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Currently, when the desktop is configured with "Folder \
view" mode, it uses the whole screen, no matter if there are panels in the area. This \
patch resizes the folder view to the available space to avoid overlaps with \
panels.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with panels on each screen side</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>containments/desktop/package/contents/ui/FolderViewLayer.qml <span style="color: \
grey">(19495b4df4afec18bc90de60ba11eb60b90c52a5)</span></li>
<li>containments/desktop/package/contents/ui/main.qml <span style="color: \
grey">(c546236abf6376963180ffec648d412bcd6e40db)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123884/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/0572c44b-1f06-46ab-86ad-9aa626c0dc2b__with_overlap.jpg">Without \
the patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8e137ad4-6a6d-4a9c-b9b9-3b9bd7bf05ec__without_overlap.jpg">With \
the patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7685902804091761185==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic