'Re: Review Request 123912: AppletAlternatives.qml: Rename caption "Alternatives" to "Alternative Wid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123912: AppletAlternatives.qml: Rename caption "Alternatives" to "Alternative Wid
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-05-27 12:37:57
Message-ID: 20150527123757.31615.16995 () mimi ! kde ! org
[Download RAW message or body]

--===============5178007074459126587==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123912/#review80892
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On May 26, 2015, 11:56 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123912/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 11:56 p.m.)
> 
> 
> Review request for Plasma, Gregor Mi and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Be more specific. There is enough space for two words, no need to make
> it short.
> 
> This patch can be also applied to plasma-mediacenter.
> 
> 
> Diffs
> -----
> 
> desktoppackage/contents/explorer/AppletAlternatives.qml \
> 69da8e735bfa2656ddb07c68257f8be27a949d4a  
> Diff: https://git.reviewboard.kde.org/r/123912/diff/
> 
> 
> Testing
> -------
> 
> See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> review123912.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/26/c9a80e3a-1969-490d-9fb4-2ccd511fdb30__review123912.png
>  
> 
> Thanks,
> 
> Alexander Potashev
> 
> 

--===============5178007074459126587==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123912/">https://git.reviewboard.kde.org/r/123912/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On May 26th, 2015, 11:56 p.m. UTC, Alexander Potashev wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Gregor Mi and Marco Martin.</div>
<div>By Alexander Potashev.</div>

<p style="color: grey;"><i>Updated May 26, 2015, 11:56 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Be more specific. There is enough space for two words, \
no need to make it short.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch can be also applied to \
plasma-mediacenter.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">See screenshot.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/explorer/AppletAlternatives.qml <span style="color: \
grey">(69da8e735bfa2656ddb07c68257f8be27a949d4a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123912/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/26/c9a80e3a-1969-490d-9fb4-2ccd511fdb30__review123912.png">review123912.png</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5178007074459126587==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 