[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123671: add visibleWhileDesktopShown property
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2015-05-26 21:03:18
Message-ID: 20150526210318.31615.71109 () mimi ! kde ! org
[Download RAW message or body]
--===============1825946435208738322==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123671/
-----------------------------------------------------------
(Updated Mai 26, 2015, 9:03 nachm.)
Status
------
This change has been discarded.
Review request for Plasma and Marco Martin.
Bugs: 346837, 346933 and 347212
http://bugs.kde.org/show_bug.cgi?id=346837
http://bugs.kde.org/show_bug.cgi?id=346933
http://bugs.kde.org/show_bug.cgi?id=347212
Repository: plasma-framework
Description
-------
plasmoids only need to add
Plasmoid.visibleWhileDesktopShown: true;
to ensure their panel (and thus them) remains visible while showing the desktop
This is achieved by setting the panel transient for the (first found, under them and \
visible) desktop type window.
This is mostly relevant for the showdesktop plasmoid (for now)
Notice that all bugs are only CC, we need this to be used in the showdesktop \
plasmoid.
Diffs
-----
src/plasmaquick/appletquickitem.h dffbcf3
src/plasmaquick/appletquickitem.cpp 0748a8d
src/plasmaquick/private/appletquickitem_p.h a1ec683
Diff: https://git.reviewboard.kde.org/r/123671/diff/
Testing
-------
added/removed (multiple) showdesktop plasmoids - panel transient for correct desktop \
window (and visible) unless the last is gone (they seem to be deleted with a short \
random delay?)
Thanks,
Thomas Lübking
--===============1825946435208738322==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123671/">https://git.reviewboard.kde.org/r/123671/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Mai 26, 2015, 9:03 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=346837">346837</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=346933">346933</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=347212">347212</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasmoids only need to add \
Plasmoid.visibleWhileDesktopShown: true; to ensure their panel (and thus them) \
remains visible while showing the desktop</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is achieved by \
setting the panel transient for the (first found, under them and visible) desktop \
type window.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is mostly relevant for the showdesktop plasmoid \
(for now)</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Notice that all bugs are only CC, we need this to be \
used in the showdesktop plasmoid.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">added/removed (multiple) showdesktop plasmoids - panel \
transient for correct desktop window (and visible) unless the last is gone (they seem \
to be deleted with a short random delay?)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plasmaquick/appletquickitem.h <span style="color: \
grey">(dffbcf3)</span></li>
<li>src/plasmaquick/appletquickitem.cpp <span style="color: \
grey">(0748a8d)</span></li>
<li>src/plasmaquick/private/appletquickitem_p.h <span style="color: \
grey">(a1ec683)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123671/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1825946435208738322==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic