[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-05-26 21:01:38
Message-ID: 20150526210138.31615.30590 () mimi ! kde ! org
[Download RAW message or body]
--===============5226429429292559044==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123381/
-----------------------------------------------------------
(Updated May 26, 2015, 9:01 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit ba64ae775699ae5e7d18a70e29078cc4fc5e4ead by Martin Klapetek to branch \
Plasma/5.3.
Repository: plasma-workspace
Description
-------
This returns the kde4 behavior of simply switching the icon for attention icon when animations \
are disabled.
I don't think that always using the attention icon with the pulse animation looks good, it \
looks like there's too much going on. I believe it should be an either-or. So I did it only as \
a fallback.
Diffs
-----
applets/systemtray/package/contents/ui/StatusNotifierItem.qml 5380b09
applets/systemtray/package/contents/ui/TaskDelegate.qml f2738bd
Diff: https://git.reviewboard.kde.org/r/123381/diff/
Testing
-------
I didn't test with animations off (I'm not sure how to set) so I just explicitly enabled the \
timer and disabled the PulseAnimation. Works just like in the old times.
Thanks,
Martin Klapetek
--===============5226429429292559044==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123381/">https://git.reviewboard.kde.org/r/123381/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 26, 2015, 9:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
ba64ae775699ae5e7d18a70e29078cc4fc5e4ead by Martin Klapetek to branch Plasma/5.3.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This returns \
the kde4 behavior of simply switching the icon for attention icon when animations are \
disabled.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I don't think that always using the attention icon with the \
pulse animation looks good, it looks like there's too much going on. I believe it should be an \
either-or. So I did it only as a fallback.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I didn't test \
with animations off (I'm not sure how to set) so I just explicitly enabled the timer and \
disabled the PulseAnimation. Works just like in the old times.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/systemtray/package/contents/ui/StatusNotifierItem.qml <span style="color: \
grey">(5380b09)</span></li>
<li>applets/systemtray/package/contents/ui/TaskDelegate.qml <span style="color: \
grey">(f2738bd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123381/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5226429429292559044==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic