[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123888: [krunner] Bring back history
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-05-26 10:48:11
Message-ID: 20150526104811.31615.5347 () mimi ! kde ! org
[Download RAW message or body]
--===============3298071508002427578==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123888/#review80844
-----------------------------------------------------------
+1
history feature itself works fine here.
only thing one sees how ugly the combobox is, but unfortunately most of its theming \
(at least the frame area) is private api, so would be possible to theme more \
precisely but risky
- Marco Martin
On May 23, 2015, 11:40 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123888/
> -----------------------------------------------------------
>
> (Updated May 23, 2015, 11:40 p.m.)
>
>
> Review request for Plasma, KDE Usability and Vishesh Handa.
>
>
> Bugs: 335731
> https://bugs.kde.org/show_bug.cgi?id=335731
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> This turns KRunner's TextField into an editable ComboBox to provide a history.
>
> When a result is invoked, the query string is prepended to the history, query \
> strings are only added once. ComboBox provides letter-by-letter auto completion.
>
> Diffs
> -----
>
> krunner/view.h 1ad5075
> krunner/view.cpp 8640e1d
> lookandfeel/contents/runcommand/RunCommand.qml 4c6eb30
>
> Diff: https://git.reviewboard.kde.org/r/123888/diff/
>
>
> Testing
> -------
>
> Somehow I have a feeling it doesn't always save the history or nukes it at times. \
> It also has some shortcomings due to ComboBox:
> 1.) You cannot use the arrow keys to cycle between entries (when the popup's not \
> opened) because arrow keys navigate through results 2.) forceActiveFocus() on the \
> ComboBox will not activate the embedded TextField - when you had opened the popup \
> there's a slight chance the input field won't get focussed I'll prepare a Qt patch \
> for this. 3.) Before Qt 5.4.2 (not sure if my patch ended up in 5.4.1) pressing \
> space in the edit combobox will open the popup, not insert a space (nasty show \
> stopper) 4.) Plasma's edtiable ComboBox looks a bit strange imho
> 5.) Plasma's editable ComboBox doesn't support clearButtonShown
> 6.) Plasma's ComboBox has strange bullets and margins in it, that's probably a bug \
> in Plasma Style (need to look what Desktop style does differently from us) 7.) \
> ComboBox doesn't have a cursorPosition, I'll prepare a Qt patch for this.
>
> File Attachments
> ----------------
>
> History popup
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/7ad7e5eb-4874-4f9f-9796-738fa2ac9ed5__krunnerhistory.png
> Auto completion
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/18714844-ef28-4cdd-af00-e6685caece9b__krunnerautocompletion.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============3298071508002427578==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123888/">https://git.reviewboard.kde.org/r/123888/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">+1 \
history feature itself works fine here. only thing one sees how ugly the combobox is, \
but unfortunately most of its theming (at least the frame area) is private api, so \
would be possible to theme more precisely but risky</p></pre> <br />
<p>- Marco Martin</p>
<br />
<p>On May 23rd, 2015, 11:40 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 23, 2015, 11:40 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=335731">335731</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This turns KRunner's TextField into an editable \
ComboBox to provide a history.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">When a result is \
invoked, the query string is prepended to the history, query strings are only added \
once. ComboBox provides letter-by-letter auto completion.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Somehow I have a feeling it doesn't always save the \
history or nukes it at times. It also has some shortcomings due to ComboBox:</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">1.) You cannot use the arrow keys to cycle between entries (when the \
popup's not opened) because arrow keys navigate through results 2.) \
forceActiveFocus() on the ComboBox will not activate the embedded TextField - when \
you had opened the popup there's a slight chance the input field won't get focussed \
I'll prepare a Qt patch for this. 3.) Before Qt 5.4.2 (not sure if my patch ended up \
in 5.4.1) pressing space in the edit combobox will open the popup, not insert a space \
(nasty show stopper) 4.) Plasma's edtiable ComboBox looks a bit strange imho
5.) Plasma's editable ComboBox doesn't support clearButtonShown
6.) Plasma's ComboBox has strange bullets and margins in it, that's probably a bug in \
Plasma Style (need to look what Desktop style does differently from us) 7.) ComboBox \
doesn't have a cursorPosition, I'll prepare a Qt patch for this.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/view.h <span style="color: grey">(1ad5075)</span></li>
<li>krunner/view.cpp <span style="color: grey">(8640e1d)</span></li>
<li>lookandfeel/contents/runcommand/RunCommand.qml <span style="color: \
grey">(4c6eb30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123888/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/7ad7e5eb-4874-4f9f-9796-738fa2ac9ed5__krunnerhistory.png">History \
popup</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/18714844-ef28-4cdd-af00-e6685caece9b__krunnerautocompletion.png">Auto \
completion</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3298071508002427578==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic