'Re: Review Request 123834: Switch the login sound to Phonon directly...for now'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123834: Switch the login sound to Phonon directly...for now
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-05-26 9:24:08
Message-ID: 20150526092408.31615.39204 () mimi ! kde ! org
[Download RAW message or body]

--===============3591784007105924119==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123834/
-----------------------------------------------------------

(Updated May 26, 2015, 9:24 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit c445f99304bd0190a7a0b83e4700222132bc34d1 by Martin Klapetek to \
branch master.

Repository: plasma-workspace

Description
-------

With its current architecture, KNotification can cause crashes on logout (and also \
cause asserts in certain situations, that will be another fix). So in the meantime, \
this replaces the KNotification-in-a-thread with Phonon directly.

This is exactly what KNotification would do. This is for the time being until the \
crash on logout is sorted out.

Additionally, this also fixes logout sound which was missing before. This uses normal \
KNotification as at that point we don't need to be threading or anything, so \
KNotification is just safe.

Diffs
-----

  CMakeLists.txt 8ffccad 
  ksmserver/CMakeLists.txt c0543e2 
  ksmserver/shutdown.cpp 7600c30 
  ksmserver/startup.cpp f79fd4f 

Diff: https://git.reviewboard.kde.org/r/123834/diff/

Testing
-------

Login sound works as expected, logout sound as well. Also tested by couple other \
people.

Thanks,

Martin Klapetek

--===============3591784007105924119==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123834/">https://git.reviewboard.kde.org/r/123834/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated May 26, 2015, 9:24 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit c445f99304bd0190a7a0b83e4700222132bc34d1 by Martin \
Klapetek to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With its current architecture, KNotification can cause \
crashes on logout (and also cause asserts in certain situations, that will be another \
fix). So in the meantime, this replaces the KNotification-in-a-thread with Phonon \
directly.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is exactly what KNotification would do. This is \
for the time being until the crash on logout is sorted out.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Additionally, this also fixes logout sound which was missing before. This \
uses normal KNotification as at that point we don't need to be threading or anything, \
so KNotification is just safe.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Login sound works as expected, logout sound as well. \
Also tested by couple other people.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(8ffccad)</span></li>

 <li>ksmserver/CMakeLists.txt <span style="color: grey">(c0543e2)</span></li>

 <li>ksmserver/shutdown.cpp <span style="color: grey">(7600c30)</span></li>

 <li>ksmserver/startup.cpp <span style="color: grey">(f79fd4f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123834/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3591784007105924119==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 