--===============9113568092070054983== Content-Type: multipart/alternative; boundary="===============6701611981921114697==" --===============6701611981921114697== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/#review80767 ----------------------------------------------------------- In addition to the comments, just one nitpick: The first group header should be "Font", not "Appearance". - Thomas Pfeiffer On May 22, 2015, 9:05 a.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123877/ > ----------------------------------------------------------- > > (Updated May 22, 2015, 9:05 a.m.) > > > Review request for Plasma and KDE Usability. > > > Bugs: 348072 > https://bugs.kde.org/show_bug.cgi?id=348072 > > > Repository: plasma-workspace > > > Description > ------- > > This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible? > > > Diffs > ----- > > applets/digital-clock/package/contents/config/main.xml 5237160 > applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 > applets/digital-clock/package/contents/ui/configAppearance.qml 669b1cc > > Diff: https://git.reviewboard.kde.org/r/123877/diff/ > > > Testing > ------- > > Checking and unchecking the custom color checkbox properly sets/unsets the color, the "Default" font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken. > > > File Attachments > ---------------- > > The clock > https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/1a6c37c2-5a11-4692-b658-241f2c3073af__uglyclock.png > Settings > https://git.reviewboard.kde.org/media/uploaded/files/2015/05/21/226b7028-69cf-4f6e-87db-2ba37ad3be29__uglyclock2.png > > > Thanks, > > Kai Uwe Broulik > > --===============6701611981921114697== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123877/

In addition to the comments, just one nitpick: The first group header should be "Font", not "Appearance".

- Thomas Pfeiffer

On May 22nd, 2015, 9:05 a.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma and KDE Usability.

By Kai Uwe Broulik.

Updated May 22, 2015, 9:05 a.m.

Bugs: 348072

Repository: plasma-workspace

Description

This restores the custom font family and font color options; also clean ups the layout a bit - we don't have a FormLayout, so that's the best it can get. Did I mention dealing with ComboBox is horrible?

Testing

Checking and unchecking the custom color checkbox properly sets/unsets the color, the "Default" font option restores the default font, options in the dialog are properly restored when it opens, Apply button does not appear to have become broken.

Diffs

applets/digital-clock/package/contents/config/main.xml (5237160)
applets/digital-clock/package/contents/ui/DigitalClock.qml (a142d33)
applets/digital-clock/package/contents/ui/configAppearance.qml (669b1cc)

File Attachments

--===============6701611981921114697==-- --===============9113568092070054983== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============9113568092070054983==--