[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-05-23 19:40:08
Message-ID: 20150523194008.17018.12200 () mimi ! kde ! org
[Download RAW message or body]
--===============8935888472159035515==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Mai 22, 2015, 2:35 nachm., David Edmundson wrote:
> > File Attachment: fonts qml port - fonts_qml2.png
> > <https://git.reviewboard.kde.org/r/123682/#fcomment405>
> >
> > Can we make this a component in KQuickControls would be useful for a few applets. \
> > (thinking of Kai's last patch to digital clock)
+1
Btw any progress on your "simple frame for QQC" approach? I kinda dislike the \
hardcoded Rectangle
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123682/#review80730
-----------------------------------------------------------
On Mai 19, 2015, 2:47 nachm., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123682/
> -----------------------------------------------------------
>
> (Updated Mai 19, 2015, 2:47 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This patch ports the kcm fonts to QML.
>
>
> Diffs
> -----
>
> kcms/fonts/CMakeLists.txt d73636e
> kcms/fonts/fonts.cpp 74da799
> kcms/fonts/fonts.desktop 5b486ed
> kcms/fonts/fonts.h d98bbe2
> kcms/fonts/kcm_fonts.desktop PRE-CREATION
> kcms/fonts/package/contents/ui/main.qml PRE-CREATION
> kcms/fonts/package/metadata.desktop PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123682/diff/
>
>
> Testing
> -------
>
> Everything works execpt from the ComboBox and the FontDialog ("Configure Font").
>
> * FontDialog
>
> If you open the kcm inside from the system settings, everything is ok.
>
> If you use kcmshell5 fonts, the FontDialog is opening behing the kcm window.
> In order to solve this issue we must use the setTransientParent, but how can
> i do that in the FontDialog?
>
> * ComboBox
>
> If you open the kcm with the "kcmshell5 fonts", the dropdown menu renders fine.
>
> But if you open it inside from the system settings, the dropdown menu, renders
> in the left of the ComboBox.
>
>
> Also these two signals (main.qml line 295)
>
> onDpiChanged
> onAliasingChanged
>
> are being emitted but the kcm.needsSave doesn't work...
>
>
> File Attachments
> ----------------
>
> fonts qml port
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/19/467d70b7-69c8-4ad1-8da5-db0e9320bc03__fonts_qml2.png
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
--===============8935888472159035515==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123682/">https://git.reviewboard.kde.org/r/123682/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Mai 22nd, 2015, 2:35 nachm. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td>
<a href="https://git.reviewboard.kde.org/r/123682/file/2102/" style="color: \
black; font-weight: bold; font-size: 9pt;">fonts_qml2.png</a>
<p>fonts qml port</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can we make this a \
component in KQuickControls would be useful for a few applets. (thinking of Kai's \
last patch to digital clock)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">+1</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Btw any progress on your "simple frame for QQC" \
approach? I kinda dislike the hardcoded Rectangle</p></pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Mai 19th, 2015, 2:47 nachm. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Mai 19, 2015, 2:47 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch ports the kcm fonts to QML.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Everything works execpt from the ComboBox and the \
FontDialog ("Configure Font").</p> <ul style="padding: 0;text-rendering: \
inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;"> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">FontDialog</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If you open the kcm inside from the system settings, \
everything is ok.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If you use kcmshell5 fonts, the \
FontDialog is opening behing the kcm window. In order to solve this issue we must use \
the setTransientParent, but how can i do that in the FontDialog?</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">ComboBox</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">If you open the kcm with the "kcmshell5 fonts", the \
dropdown menu renders fine.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">But if you open it inside from the \
system settings, the dropdown menu, renders in the left of the ComboBox.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also these two signals (main.qml line 295)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">onDpiChanged onAliasingChanged </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">are being emitted but the kcm.needsSave doesn't \
work...</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/fonts/CMakeLists.txt <span style="color: grey">(d73636e)</span></li>
<li>kcms/fonts/fonts.cpp <span style="color: grey">(74da799)</span></li>
<li>kcms/fonts/fonts.desktop <span style="color: grey">(5b486ed)</span></li>
<li>kcms/fonts/fonts.h <span style="color: grey">(d98bbe2)</span></li>
<li>kcms/fonts/kcm_fonts.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/fonts/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/fonts/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123682/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/19/467d70b7-69c8-4ad1-8da5-db0e9320bc03__fonts_qml2.png">fonts \
qml port</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8935888472159035515==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic